Skip to content

ci: remove retired verify-pr-fullsend branch filters - #337

Merged
mrizzi merged 1 commit into
mainfrom
TC-6358
Oct 14, 2026
Merged

mrizzi merged 1 commit into
mainfrom
TC-6358

Conversation

@mrizzi

@mrizzi mrizzi commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Post-graduation cleanup after verify-pr-fullsend merged to main (PR #299, merge commit 27ad1c49).

  • validate-plugins.yml, skillsaw.yml, python-tests.yml: push/pull_request filters reduced to branches: [main]; TEMPORARY rollout comments removed.
  • fullsend-verify-pr.yml: pull_request_target filter reduced to branches: [main]; graduation-specific comments removed. Security model (pull_request_target + ok-to-test), permissions and dispatch logic unchanged.
  • eval-pr.yml / eval-pr-run.yml: untouched — already main-only (no dynamic-base eval path from the closed PR feat(workflow): enable integration-branch eval dispatch #309).
  • docs/specs/2026-05-07-eval-pr-fork-dispatch-design.md: no change needed — it contains no verify-pr-fullsend references.

Verification

  • git diff --check — clean
  • rg -n "verify-pr-fullsend" .github/workflows — no matches
  • All workflow YAML parses
  • uvx skillsaw — 0 errors (grade A)
  • claude plugin validate plugins/sdlc-workflow — passed
  • This PR targets main, so it exercises validation, Fullsend verify-pr and eval triggers itself.

Implements TC-6358

🤖 Generated with Claude Code

Summary by Sourcery

Remove retired verify-pr-fullsend branch filters and finalize main-only CI workflow triggers.

Enhancements:

  • Restrict validation, linting, Python tests, and Fullsend PR verification workflows to the main branch after the feature branch graduated.
  • Remove obsolete rollout and graduation-specific workflow comments.

The verify-pr-fullsend integration branch graduated to main (PR #299,
merge commit 27ad1c4). Drop it from the push/pull_request branch filters
of validate-plugins, skillsaw and python-tests, and from the
pull_request_target filter of fullsend-verify-pr, along with the
temporary rollout comments. Workflows keep triggering for main only; the
pull_request_target security model, permissions and the main-only eval
workflows (eval-pr.yml, eval-pr-run.yml) are unchanged.

Implements TC-6358

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-by: Claude Code
@sourcery-ai

sourcery-ai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This cleanup removes retired verify-pr-fullsend branch filters and associated rollout comments, leaving validation, testing, and Fullsend verification workflows triggered only for changes targeting or pushed to main; existing security and dispatch behavior remains unchanged.

File-Level Changes

Change Details Files
Restrict CI and Fullsend verification triggers to the supported default branch after feature graduation.
  • Removed verify-pr-fullsend from push and pull-request branch filters.
  • Kept pull_request_target verification behavior, permissions, security gating, and dispatch logic unchanged while limiting it to main.
  • Removed temporary rollout and graduation-specific comments.
.github/workflows/validate-plugins.yml
.github/workflows/skillsaw.yml
.github/workflows/python-tests.yml
.github/workflows/fullsend-verify-pr.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:04 PM UTC · Completed 2:14 PM UTC

Commit: 6b23425 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-8 · Effort: high · Cost: $4.96

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 13, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

A small CI-only change deleting branch filters across four protected .github/workflows files carries moderate risk from the protected CI paths, but is tempered by minimal line changes, a trusted human author, and a quiet, low-churn git history with no source, test, or dependency impact.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] .github/workflows/ — This PR modifies governance/infrastructure files under the protected path .github/: .github/workflows/fullsend-verify-pr.yml, .github/workflows/python-tests.yml, .github/workflows/skillsaw.yml, and .github/workflows/validate-plugins.yml. The PR links to Jira TC-6358 and explains the rationale (post-graduation cleanup of the retired verify-pr-fullsend branch filters after PR feat(fullsend): integrate verify-pr and triage-security (TC-6201) #299 merged to main). Human approval is always required for protected-path changes, regardless of context.

Notes

  • The change is a fail-closed reduction of CI trigger scope: branches: on all four workflows is narrowed from [main, verify-pr-fullsend] to [main], removing the retired feature branch. The privileged pull_request_target workflow's permissions:, secrets:, ok-to-test fork gate, and no-fork-checkout dispatch model are unchanged — security posture is unchanged-to-reduced. No CI coverage regression for main PRs, and no stale verify-pr-fullsend references were introduced (remaining doc mentions are historical rollout narration).
  • Minor: the removed TEMPORARY comments tracked this cleanup under TC-5816, while the PR body cites TC-6358. Worth a one-line confirmation that TC-6358 is the intended tracker (no code change required).

@fullsend-ai-review

fullsend-ai-review Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🤖 Finished Verify Pr · ✅ Success · Started 9:49 AM UTC · Completed 10:03 AM UTC

Commit: 6b23425 · View workflow run →

Runtime: claude · Model: claude-opus-4-8 · Effort: high · Cost: $5.03

@fullsend-ai-review

Copy link
Copy Markdown

Verification Report for TC-6358 (commit 6b23425)

Check Result Details
Review Feedback N/A No inline review comments and no substantive review-body feedback (only a bare Sourcery approval).
Root-Cause Investigation N/A No sub-tasks created; nothing to investigate.
Scope Containment PASS All four required workflow files changed; the conditional design-doc update was correctly skipped (doc has no verify-pr-fullsend references).
Diff Size PASS 10 insertions / 32 deletions across 4 files — proportionate, deletion-heavy cleanup.
Commit Traceability PASS Single commit references TC-6358 (Implements TC-6358).
Sensitive Patterns PASS No secrets or credentials in added lines.
CI Status PASS All head-SHA checks pass (success/skipped); none failed or pending.
Acceptance Criteria PASS 8 of 8 criteria met.
Test Quality N/A No test files and no eval reviews (Repetitive Test, Test Documentation, Eval Quality all N/A).
Test Change Classification N/A No test files added, modified, or deleted.
Verification Commands PASS rg cleanup verified via base+diff (15->0); git diff --check clean; skillsaw & plugin-validate confirmed by passing CI.

Overall: PASS

CI-only cleanup removing the retired verify-pr-fullsend branch filters and temporary rollout comments from four workflows, leaving main-only triggers intact. All 8 acceptance criteria are satisfied, no secrets, the single commit is traceable to TC-6358, and all head-SHA CI checks pass. fullsend-verify-pr.yml keeps its pull_request_target security model (only the branch list narrowed to [main]), and eval-pr.yml / eval-pr-run.yml are unchanged (still main-only). No review feedback required sub-tasks. This report is informational — a human reviewer decides whether to merge.


This comment was AI-generated by sdlc-workflow/verify-pr v0.13.10.

@mrizzi
mrizzi merged commit 5436ac4 into main Oct 14, 2026
77 of 79 checks passed
@mrizzi
mrizzi deleted the TC-6358 branch October 14, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant