Skip to content

Gate connections on notification access #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
R055LE merged 1 commit into from
Sep 6, 2026
Merged

Gate connections on notification access #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions PROJECT_SPEC.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,12 @@ Home has explicit task states:
The selected Home task and non-secret connection draft survive Android saved-state restoration.
Returning Home from the active session always starts at its active-session dashboard.

On Android versions that require notification permission, explain the ongoing session notification
and resolve permission before showing credential inputs. A denial leaves the non-secret connection
draft in place, offers one retry plus Android notification settings, and routes repeated denial to
Settings. Recheck permission when the app resumes. Never prepare or start SSH while Threadline's
required session notification is unavailable.

A saved host profile contains:

- Display name
Expand Down
198 changes: 198 additions & 0 deletions app/src/androidTest/java/dev/threadline/ConnectionFormRetentionTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,204 @@ class ConnectionFormRetentionTest {
compose.onNodeWithTag(ConnectionFormTags.HOSTNAME).assertIsFocused()
}

@Test
fun notificationPermissionStateTracksFirstAndRepeatedDenial() {
assertEquals(
SessionNotificationPermissionState.REQUESTABLE,
sessionNotificationPermissionState(granted = false, denialCount = 0),
)
assertEquals(
SessionNotificationPermissionState.DENIED,
sessionNotificationPermissionState(granted = false, denialCount = 1),
)
assertEquals(
SessionNotificationPermissionState.SETTINGS_REQUIRED,
sessionNotificationPermissionState(granted = false, denialCount = 2),
)
assertEquals(
SessionNotificationPermissionState.GRANTED,
sessionNotificationPermissionState(granted = true, denialCount = 2),
)
}

@Test
fun notificationPermissionIsExplainedBeforeCredentialEntryAndFirstGrantUnlocksForm() {
val permissionState = mutableStateOf(SessionNotificationPermissionState.REQUESTABLE)
var requestCount = 0
var preparedCount = 0
compose.setContent {
MaterialTheme {
HostForm(
draft = ConnectionFormDraft.fixtureDefaults(),
onDraftChange = {},
sessionError = null,
notificationPermissionState = permissionState.value,
onRequestNotificationPermission = { requestCount += 1 },
onPrepared = {
preparedCount += 1
it.credential.clear()
true
},
)
}
}

compose.onNodeWithText("Keep active SSH sessions visible")
.performScrollTo()
.assertIsDisplayed()
compose.onNodeWithText(
"Allow session notifications before entering a password or passphrase.",
substring = true,
).assertIsDisplayed()
compose.onNodeWithTag(ConnectionFormTags.PASSWORD).assertDoesNotExist()
compose.onNodeWithTag(ConnectionFormTags.CONNECT).assertDoesNotExist()

compose.onNodeWithTag(ConnectionFormTags.REQUEST_NOTIFICATION_PERMISSION)
.performClick()
compose.runOnIdle {
assertEquals(1, requestCount)
assertEquals(0, preparedCount)
permissionState.value = SessionNotificationPermissionState.GRANTED
}

compose.onNodeWithTag(ConnectionFormTags.PASSWORD)
.performScrollTo()
.assertIsDisplayed()
compose.onNodeWithTag(ConnectionFormTags.CONNECT).assertExists()
}

@Test
fun notificationDenialAllowsRetryAndRepeatedDenialRoutesToSettings() {
val draft = mutableStateOf(ConnectionFormDraft.fixtureDefaults())
val permissionState = mutableStateOf(SessionNotificationPermissionState.REQUESTABLE)
var requestCount = 0
var settingsOpenCount = 0
var preparedCount = 0
compose.setContent {
MaterialTheme {
HostForm(
draft = draft.value,
onDraftChange = { draft.value = it },
sessionError = null,
notificationPermissionState = permissionState.value,
onRequestNotificationPermission = { requestCount += 1 },
onOpenNotificationSettings = { settingsOpenCount += 1 },
onPrepared = {
preparedCount += 1
it.credential.clear()
true
},
)
}
}

compose.onNodeWithTag(ConnectionFormTags.HOSTNAME)
.performTextReplacement("changed.example")
compose.onNodeWithTag(ConnectionFormTags.REQUEST_NOTIFICATION_PERMISSION)
.performScrollTo()
.performClick()
compose.runOnIdle {
permissionState.value = SessionNotificationPermissionState.DENIED
}
compose.onNodeWithText("Notification access is still off")
.performScrollTo()
.assertIsDisplayed()
compose.onNodeWithTag(ConnectionFormTags.PASSWORD).assertDoesNotExist()
compose.onNodeWithTag(ConnectionFormTags.CONNECT).assertDoesNotExist()
compose.onNodeWithTag(ConnectionFormTags.HOSTNAME)
.assertEditableTextEquals("changed.example")
compose.onNodeWithTag(ConnectionFormTags.OPEN_NOTIFICATION_SETTINGS)
.performScrollTo()
.performClick()
compose.onNodeWithTag(ConnectionFormTags.REQUEST_NOTIFICATION_PERMISSION)
.performScrollTo()
.performClick()

compose.runOnIdle {
assertEquals(2, requestCount)
assertEquals(1, settingsOpenCount)
assertEquals(0, preparedCount)
permissionState.value = SessionNotificationPermissionState.SETTINGS_REQUIRED
}
compose.onNodeWithTag(ConnectionFormTags.REQUEST_NOTIFICATION_PERMISSION)
.assertDoesNotExist()
compose.onNodeWithTag(ConnectionFormTags.OPEN_NOTIFICATION_SETTINGS)
.performScrollTo()
.performClick()
compose.runOnIdle {
assertEquals(2, settingsOpenCount)
assertEquals(0, preparedCount)
}
}

@Test
fun settingsRecoveryRevealsAnEmptyCredentialField() {
val permissionState = mutableStateOf(SessionNotificationPermissionState.GRANTED)
var settingsOpenCount = 0
compose.setContent {
MaterialTheme {
HostForm(
draft = ConnectionFormDraft.fixtureDefaults(),
onDraftChange = {},
sessionError = null,
notificationPermissionState = permissionState.value,
onOpenNotificationSettings = { settingsOpenCount += 1 },
onPrepared = { true },
)
}
}

compose.onNodeWithTag(ConnectionFormTags.PASSWORD)
.performTextReplacement("session-only")
compose.runOnIdle {
permissionState.value = SessionNotificationPermissionState.SETTINGS_REQUIRED
}
compose.onNodeWithTag(ConnectionFormTags.PASSWORD).assertDoesNotExist()
compose.onNodeWithTag(ConnectionFormTags.OPEN_NOTIFICATION_SETTINGS)
.performScrollTo()
.performClick()
compose.runOnIdle {
assertEquals(1, settingsOpenCount)
permissionState.value = SessionNotificationPermissionState.GRANTED
}

compose.onNodeWithTag(ConnectionFormTags.PASSWORD)
.performScrollTo()
.assertEditableTextEquals("")
}

@Test
fun alreadyGrantedPermissionConnectsWithoutShowingTheGate() {
var preparedCount = 0
compose.setContent {
MaterialTheme {
HostForm(
draft = ConnectionFormDraft.fixtureDefaults(),
onDraftChange = {},
sessionError = null,
notificationPermissionState = SessionNotificationPermissionState.GRANTED,
onPrepared = {
preparedCount += 1
it.credential.clear()
true
},
)
}
}

compose.onNodeWithTag(ConnectionFormTags.NOTIFICATION_PERMISSION).assertDoesNotExist()
compose.onNodeWithTag(ConnectionFormTags.PASSWORD)
.performScrollTo()
.performTextReplacement("session-only")
compose.onNodeWithTag(ConnectionFormTags.CONNECT)
.performScrollTo()
.performClick()
compose.waitForIdle()

compose.runOnIdle { assertEquals(1, preparedCount) }
compose.onNodeWithTag(ConnectionFormTags.PASSWORD).assertEditableTextEquals("")
}

@Test
fun notificationFailureOnlyOpensSettingsAfterTheUserAction() {
var settingsOpenCount = 0
Expand Down
Loading