Remove dead feed-curation tools, feed_fetch.py, and store's feed methods - #57
Merged
Merged
Conversation
ADR-0012 deferred this cleanup deliberately so the source-swap PR stayed reviewable on its own. Now that Scout is the live source for Digest, the personal digest, and Spark, nothing reads the feeds/personal_feeds tables or calls add_feed/remove_feed/list_feeds/suggest_feeds (or their personal variants) any more. Also fixes two latent bugs the removal exposed: _digest_status gated on feeds_count and would have permanently read "no feeds" once the feeds table went empty, and _PERSONAL_DIGEST_OK_PREFIXES carried a "personal digest not configured" prefix the job hasn't emitted since the Scout migration. Docs (README/ARCHITECTURE/BACKLOG) updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_feeds/suggest_feeds/add_feed/remove_feed+ personal variants),roger/feed_fetch.py, and the store'sfeeds/personal_feedstables and methods — all dead since Replace feed fetching with Scout as the item source #56 moved Digest/Spark/personal digest onto Scout.feedparserdependency (its only caller wasfeed_fetch.py).roger_feedsPrometheus gauge._digest_statusgated onfeeds_countand would have permanently reported "no feeds" once the table stayed empty forever — the gate is gone, status now falls through to the last scheduled attempt._PERSONAL_DIGEST_OK_PREFIXEScarried a"personal digest not configured"prefix the job hasn't emitted since the Scout migration — removed as dead.Why
ADR-0012 deferred this on purpose: keeping the source-swap change small and reviewable. Now that Scout has been running in production for a bit, this is the promised follow-up.
Test plan
ruff check .cleanpython -m pytest --cov=roger --cov-fail-under=75— 473 passed, 84.83% coverage (down from 563 tests / 86.53% pre-removal — the difference is exactly the deleted dead-code tests)