New nvimcom option: max_cpu_cores#594
Conversation
|
Good job. Should we also give an example about using options(nvimcom.max_cpu_cores = as.integer(Sys.getenv("SLURM_CPUS_PER_TASK")) |
Yes, if the variable will always be set for Slurm users in the normal way of using Slurm (which, according to Gemini, isn't through SSH). I have zero experience with HPC Clusters. |
|
I will add something. |
…urm environment variable
|
I think this is good to merge. Ok with you? |
|
It's OK for me. Should we wait a while for @daler's comments? |
I think so! |
daler
left a comment
There was a problem hiding this comment.
Tested, and works great -- thanks for such quick turnaround.
I made some adjustments to the docs to make it a little more general while still keeping the concrete Slurm-specific example, and slightly tweaked the example to have a max of 2 in case the env var is unavailable, like if you don't use --cpus-per-task.
|
Thank you, @daler! Let's wait for @PMassicotte final review. |
Co-authored-by: Ryan Dale <115406+daler@users.noreply.github.com>
|
LGTM! Merging, thank you all for your contributions. |
Close #593