Skip to content

Fix/deprecated api warnings from lighthouse#696

Closed
AlexJohnSadowski wants to merge 0 commit into
QwikDev:mainfrom
AlexJohnSadowski:fix/deprecated-api-warnings-from-lighthouse
Closed

Fix/deprecated api warnings from lighthouse#696
AlexJohnSadowski wants to merge 0 commit into
QwikDev:mainfrom
AlexJohnSadowski:fix/deprecated-api-warnings-from-lighthouse

Conversation

@AlexJohnSadowski

Copy link
Copy Markdown
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

#694
#693

I've noticed that myself and decided to quickly fix it, cause it's dragging my lighthouse score significantly.

Partytown's readImplementationMember() iterates over all window properties and accesses their values to build the platform API map for the web worker and by just simply reading window.sharedStorage, window.attributionReporting, and related properties triggers Chrome deprecation warnings, hence the bugs mentionned from the repo's issues section.

Added these deprecated property names to the isValidMemberName deny list in utils.ts so they're skipped during introspection. I noticed the same approach used for the Event.path fix in PR #328, so it should be a good-enough band-aid for now, cause it's TANKING the score.

BEFORE:

image

AFTER
The warnings are gone.
image

Use cases and why

Cause it's dragging the beautiful green lighthouse score to the orange one and it triggers my OCD.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation.
  • Added new tests to cover the fix / functionality -> I built it, linked it and checked it myself on my pet project that had the same issue.

@changeset-bot

changeset-bot Bot commented Feb 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 14d6b20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant