Repository navigation
feat(release): say plainly which file to download, one version per page - #32
Open
QuicksilverSlick wants to merge 3 commits into
Open
QuicksilverSlick wants to merge 3 commits into
QuicksilverSlick wants to merge 3 commits into
Conversation
The release page now opens with a table: Windows PC, Mac with an Apple chip, Mac with an Intel chip, each linking its exact file, plus how to tell which Mac you have and step-by-step install for both. The text lives in scripts/dreamforge-release-notes.md; the publish job fills in the version and links, sets the title to "Dreamforge <version>", rewrites the notes on every publish, and after latest.json is uploaded removes the previous version's files so the page only ever shows one set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Publish: the notes edit now runs before latest.json goes live, and the old-file cleanup after it only warns (a failure there used to turn a shipped release red, and a rerun is refused as not newer). The asset list is captured without a pipe, since the publish job's bash has no pipefail. The pre-publish check now also requires both DMGs the page links. Page: Mac steps say to click Done, not Move to Trash, that Open Anyway lasts about an hour, and that it asks for the login password; chip guidance covers A-series Macs and matches About This Mac's Chip and Processor lines; Windows steps cover Edge's isn't-commonly-downloaded prompt and Smart App Control; the certificate wording is corrected; and updates are described as the Ready to update! card they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The release page read as a file list for developers. It now tells a visitor which single file is theirs.
scripts/dreamforge-release-notes.md: the page text. It opens with a table (Windows PC, Mac with an Apple chip, Mac with an Intel chip), where each row links its exact file. Then it explains how to tell which Mac you have, gives numbered install steps for Windows and Mac, and says which files to ignore (.app.tar.gz,.sig,latest.json, and GitHub's "Source code").{VERSION}and{BASE}into the template and refuses to continue if a placeholder is left;Dreamforge <version>and rewrites the notes on every publish, not only the first;latest.jsonis uploaded, deletes assets from earlier versions, so the page shows one set.latest.jsonno longer names those files. A failure there only warns, because the release is already live by then and a rerun would be refused as "not newer". The notes edit runs beforelatest.json, for the same reason.VERSIONis already plainx.y.zat that point, because "Write latest.json" refuses anything else. So thesedinput can't carry anything unexpected.Review
Two reviewers checked this PR, one for publish-step correctness and one for install-step accuracy against Apple and Microsoft documentation. All six findings were applied in the second commit:
pipefailin the publish job's bash, so the asset list is captured without a pipe;Verified
0.5.220), keepslatest.jsonand the_0.5.22_files and deletes the rest.bash -ewith a fakeghwhose asset listing, and separately one delete, fails. Both runs finish 0 and print the warning.gh release edit.🤖 Generated with Claude Code