Rewrite Sign and Text-Display Rendering Code to be more Flexible and Reusable#2417
Merged
creatorfromhell merged 7 commits intoJun 27, 2026
Conversation
Contributor
|
Latest build artifacts are available for this PR. Commit: 43ba8e1 Download the artifact named: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do?
RenderComponent System
The render component system replaces the current sign layout system and the text-display system, combining both into a single flexible rendering system.
The layout options for signs retain the current iteration (
header,trading,item,level,price), while introducing greater customization. Components are now divided into three categories:Full Line Components
header– shop owner/availability headeritem– formatted item displaylevel– item level/duration lineprice– complete price line with stacking shop supporttrading– trading/stock status lineInline Components
<amount>– item amount<item_name>– item display name<item_level>– enchantment level, potion duration, or similar item metadata<owner>– shop owner name<price_alone>– formatted price only<price_amount>– formatted price text with stacking shop support<status>– current shop state/status<stock>– remaining stock display<type>– shop type (Buy/Sell/etc.)Conditional Components
Conditional components dynamically determine their output based on the current shop state.
<amount_auto>– Displays:Type of Change
Basic Checks
Notes (optional)
Add anything important for reviewers:
Config Changes (if applicable)
Only fill this out if you touched config:
Breaking Changes (if applicable)
Related (optional)