-
-
Notifications
You must be signed in to change notification settings - Fork 8
[render preview] Fix/UI text overflow #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
segundavid-dev
wants to merge
4
commits into
QueueLab:main
Choose a base branch
from
segundavid-dev:fix/ui-text-overflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
aba21db
fix(chat-panel): replace max-w-xs with responsive width
segundavid-dev 5897de0
fix(search-results): add line-clamp-2 to DialogDescription to prevent…
segundavid-dev e4bb5d4
fix(ui): resolve text overflow issues across chat, search, and calend…
segundavid-dev 3be12e7
fix(styles): fix overflow issues on example prompt
segundavid-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Make the new small-mobile overflow tests deterministic instead of conditionally skipping.
At Line 228 and Line 251, visibility guards allow both tests to pass without validating anything when elements are absent/closed. Add explicit setup (open dialog/select item, trigger attachment UI) and assert visibility unconditionally before overflow checks.
Suggested tightening
test('should not overflow with long attached file name', async ({ page }) => { - const attachmentButton = page.locator('[data-testid="mobile-attachment-button"]'); - if (await attachmentButton.isVisible()) { - await page.locator('input[type="file"]').setInputFiles({ - name: 'this-is-a-very-long-filename-that-should-not-overflow-the-container-on-small-screens.pdf', - mimeType: 'application/pdf', - buffer: Buffer.from('test') - }); + const attachmentButton = page.locator('[data-testid="mobile-attachment-button"]'); + await expect(attachmentButton).toBeVisible(); + await page.locator('input[type="file"]').setInputFiles({ + name: 'this-is-a-very-long-filename-that-should-not-overflow-the-container-on-small-screens.pdf', + mimeType: 'application/pdf', + buffer: Buffer.from('test') + }); - const fileContainer = page.locator('[data-testid="clear-attachment-button"]').locator('..'); - if (await fileContainer.isVisible()) { - const containerBox = await fileContainer.boundingBox(); - expect(containerBox).toBeTruthy(); - if (containerBox) { - expect(containerBox.width).toBeLessThanOrEqual(320); - } - - const bodyWidth = await page.evaluate(() => document.body.scrollWidth); - expect(bodyWidth).toBeLessThanOrEqual(321); - } - } + const fileContainer = page.locator('[data-testid="clear-attachment-button"]').locator('..'); + await expect(fileContainer).toBeVisible(); + const containerBox = await fileContainer.boundingBox(); + expect(containerBox).toBeTruthy(); + if (containerBox) expect(containerBox.width).toBeLessThanOrEqual(320); + const bodyWidth = await page.evaluate(() => document.body.scrollWidth); + expect(bodyWidth).toBeLessThanOrEqual(321); }); test('should not cause horizontal scroll with long query in search dialog', async ({ page }) => { + // open the search dialog in this test before querying description + // (use the existing trigger selector used elsewhere in this suite) const dialogDesc = page.locator('[role="dialog"] p.line-clamp-2'); - if (await dialogDesc.isVisible()) { - const descBox = await dialogDesc.boundingBox(); - expect(descBox).toBeTruthy(); - if (descBox) { - expect(descBox.width).toBeLessThanOrEqual(320); - } - - const bodyWidth = await page.evaluate(() => document.body.scrollWidth); - expect(bodyWidth).toBeLessThanOrEqual(321); - } + await expect(dialogDesc).toBeVisible(); + const descBox = await dialogDesc.boundingBox(); + expect(descBox).toBeTruthy(); + if (descBox) expect(descBox.width).toBeLessThanOrEqual(320); + const bodyWidth = await page.evaluate(() => document.body.scrollWidth); + expect(bodyWidth).toBeLessThanOrEqual(321); });🤖 Prompt for AI Agents