Repository navigation
chore(csv): remove the unused resultGridAsCsvAsync (#1537) - #1606
Merged
Merged
Conversation
It had no caller: the clipboard and export paths go through DataExportService.formatAsync. Its test and the doc reference are removed with it, and so is the dart:isolate import. Refs #1537
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
resultGridAsCsvAsyncfromlib/core/csv/result_grid_csv.dart: it has no callers (the clipboard / export path isDataExportService.formatAsync), only its own test. The test, the doc comment that pointed to it and thedart:isolateimport go with it.Scope
This covers the first item of #1537 only, so the PR says
Refs, notCloses. The second item (reduce the UI-isolate stall whenformatAsynchands a 50k x 20List<List<String>>to the worker, e.g. by formatting in chunks) needs the standalone harness from the issue to show a real gain and is not started here.Tests (not run locally; CI will)
Only the test of the removed function is deleted;
resultGridAsCsvandwriteResultGridCsvtests are untouched.Refs #1537