Repository navigation
perf(history): early-exit scanner for the history one-line preview (#1545) - #1599
Merged
Merged
Conversation
_previewOneLine collapsed whitespace over the whole query with a regex and only then cut it to 93 characters, so a 100 KB migration in the history was copied whole for every row just to show its first line. previewSqlOneLine reads characters from the start, collapses whitespace on the fly and stops once the preview is known to be longer than 96. The output is the same as before; a test compares it with the old implementation. Closes #1545
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`_previewOneLine` ran `replaceAll(RegExp(r'\s+'), ' ').trim()` over the whole query before cutting it to 93 characters, so a 50-100 KB script in the history was copied in full for every row it showed.
`previewSqlOneLine` scans from the start, collapses whitespace on the fly (same character set as the regex `\s`), skips leading whitespace, and stops as soon as the preview is known to exceed 96 characters. Output is identical to the old code; the row widget still calls `_previewOneLine`, which now delegates.
Tests (not run locally; CI will)
`test/features/workspace/sql_query_history_preview_test.dart` compares the new function with the old collapse-then-cut implementation on empty / whitespace-only / exact-boundary (96, 97) / non-ASCII-whitespace / multi-line / very long inputs, and checks the cut length.
Closes #1545