Skip to content

test(bearer): expect the no-credentials 401 at ATTACH, not on a later query #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rustyconover wants to merge 1 commit into from
Closed

test(bearer): expect the no-credentials 401 at ATTACH, not on a later query #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions test/sql/integration/bearer_auth/bearer_token.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,15 @@ ATTACH 'example' AS example_both (TYPE vgi, LOCATION '${VGI_TEST_WORKER}', beare
Cannot specify both bearer_token and oauth_refresh_token

# ============================================================================
# ATTACH without any credentials against a bearer-protected server yields a
# clean diagnostic — not the legacy "VGI OAuth: resource metadata URL must
# use HTTPS:" message that surfaced when the default OAuthCatalogAuth tried
# to feed an empty challenge into the OAuth discovery flow.
# ATTACH without any credentials against a bearer-protected server fails fast
# with a clean diagnostic. The extension calls catalog_attach eagerly during
# ATTACH, so the 401 surfaces here — at ATTACH — not on a later query. (The
# diagnostic is the actionable "no OAuth challenge" message, not the legacy
# "VGI OAuth: resource metadata URL must use HTTPS:" that surfaced when the
# default OAuthCatalogAuth fed an empty challenge into the OAuth discovery flow.)
# ============================================================================

statement ok
ATTACH 'example' AS example_no_auth (TYPE vgi, LOCATION '${VGI_TEST_WORKER}');

statement error
SELECT example_no_auth.double(1);
ATTACH 'example' AS example_no_auth (TYPE vgi, LOCATION '${VGI_TEST_WORKER}');
----
The server requires authentication but advertised no OAuth challenge

statement ok
DETACH example_no_auth;
Loading