ci: multi-transport (subprocess/http/unix) SQL E2E matrix#1
Merged
Conversation
Run the haybarn SQL suite (test/sql/*.test) over all three VGI transports, not just subprocess/stdio. The vgi extension picks the transport from the ATTACH LOCATION string, so run-integration.sh is now parameterized by $TRANSPORT and builds that string per leg: subprocess : .venv/bin/python rerank_worker.py (stdio; extension spawns it) http : http://127.0.0.1:<port> (worker booted with --http --port 0 --port-file; harness polls the port-file, then ATTACHes the URL) unix : unix:///tmp/rerank-<pid>.sock (worker booted with --unix; harness polls for the socket) http leg specifics (resolved, not gated): - httpfs is mandatory: the vgi extension routes worker-RPC HTTP through DuckDB's httpfs, so the http leg injects `INSTALL httpfs FROM core; LOAD httpfs;` after each `LOAD vgi;` in the staged tests. - waitress via the new `http` extra: pyproject + PEP 723 header now list `vgi-python[http]`; CI runs `uv sync --frozen --extra http` (relocked). - Silent-skip guard: the runner SKIPS (exit 0) any error containing "HTTP", so run-integration.sh fails the leg unless the runner reports "All tests passed (N assertions ...)" with N>0 and zero skips — no fake green. CI: integration job becomes a transport × os matrix. Unit/lint jobs unchanged. Local validation (haybarn-unittest): subprocess GREEN (21), unix GREEN (21), http GREEN (25, +4 injected httpfs INSTALL/LOAD). ruff clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the haybarn SQL suite over all three VGI transports (subprocess, http, unix), parameterizing
ci/run-integration.shby$TRANSPORTand turning the integration job into a transport × os matrix.--http --port 0 --port-file; httpfs injected into staged tests; silent-skip guard fails the leg unlessAll tests passed (N>0);httpextra (waitress) added to pyproject + PEP 723 + relocked.--unix <sock>.Unit/lint jobs unchanged.
🤖 Generated with Claude Code