Streamline CI#606
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5f5ca26. Configure here.
n13
approved these changes
Jun 25, 2026
n13
left a comment
Collaborator
There was a problem hiding this comment.
Review — Approve
Workflow-only change, and all checks (fast-checks, build & test matrix on ubuntu + macos, analysis) are green on the head commit. The one Bugbot finding (nextest doesn't run doctests) was correctly resolved by the run doctests commit, which adds a dedicated cargo test --doc step. LGTM.
What's good
sccache+Swatinem/rust-cache+ droppingcargo cleanshould meaningfully cut warm-cache build times.cargo nextest runfor parallel test execution.- Downloading the prebuilt
taplobinary instead ofcargo install taplo-cli --lockedavoids a from-source build each run (verified the release asset URL resolves). - Per-job
shared-keyvalues (including OS in the matrix) keep the caches correctly partitioned.
Non-blocking suggestions
- Pin
taploinstead oflatest.releases/latest/download/...is non-reproducible — a new taplo release can silently change formatting rules (or asset layout) and break CI without any change on our side. Pin to an explicit version tag to keep formatting deterministic. - Watch disk usage from removing
cargo clean. The old step was labeled "to free space," and nowtarget/is also cached. The matrix builds the workspace withruntime-benchmarks,try-runtime(compile) and again withfast-governance(test + doctest), so on the standard hosted runners this could get tight. It passed this run (ubuntu ~3h16m), so fine for now — just flagging it as a fragility to keep an eye on. - sccache + rust-cache is somewhat redundant. rust-cache already caches
target/and the registry; sccache adds a separate object cache on top. Harmless, but the marginal benefit may be small — and sccache won't cache theclippy-driverinvocations in the analysis job, where rust-cache does the heavy lifting. - Branch is named
beefier-runnersbutruns-onis stillubuntu-latest/macos-latest. If bumping to larger runners was part of the intent, it's not in this diff — was that deferred intentionally?
None of these block merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Workflow-only changes; test execution still uses the same locked workspace and feature flags, with only the runner and caching strategy changed.
Overview
CI is tuned for faster feedback by caching Rust builds, compiling through sccache, and running tests with cargo nextest instead of plain
cargo test.The build-and-test and analysis jobs now set
SCCACHE_GHA_ENABLED/RUSTC_WRAPPER, add mozilla-actions/sccache-action, and Swatinem/rust-cache with per-jobshared-keyvalues (including OS-specific keys on the matrix). The pre-testcargo cleanstep is removed so the compile step’s artifacts can be reused for tests.Fast checks install taplo from a released Linux binary via
curlrather thancargo install taplo-cli, avoiding a source build on every run.Reviewed by Cursor Bugbot for commit 5f5ca26. Configure here.