Repository navigation
Use accelerative_smith_iteration! in eig_trunc_pullback! - #294
Merged
Merged
Conversation
leburgel
added this pull request to stack #295
October 2, 2026 07:01
leburgel
changed the title
eig_trunc_pullback! iteration by the smallest eigenvalue and use _smith_iteration!
leburgel
force-pushed
the
lb/eig_trunc_pullback_smith
branch
2 times, most recently
from
October 2, 2026 17:04
d4fcb97 to
ed6deee
Compare
leburgel
changed the title
eig_trunc_pullback! iteration by the smallest eigenvalue and use _smith_iteration!accelerative_smith_iteration! in eig_trunc_pullback!
leburgel
marked this pull request as ready for review
October 2, 2026 17:27
Member
|
@leburgel that rebase didn't seem to work :p I have to say that I'm not yet fully convinced by this github feature 😆 |
leburgel
force-pushed
the
lb/eig_trunc_pullback_smith
branch
from
October 2, 2026 19:57
ed6deee to
d0455b9
Compare
Member
Author
|
I was lied to... |
lkdvos
approved these changes
Oct 2, 2026
Jutho
approved these changes
Oct 2, 2026
Member
|
Any way we can run the tests? |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #287, which introduces a dedicated helper for the doubling-iteration Sylvester solve.
Changes:
_smith_iteration!helper, as already done foreigh_trunc_pullback!andsvd_trunc_pullback!in Sum only one Neumann series insvd_trunc_pullback!#287.APᴴ = A' - ViG * (V * D)'directly rather thanAP, so the helper receives a plain matrix instead of anAdjoint, which avoids generic fallbacks on GPU.Behavioural note: as for
eigh_trunc_pullback!in #287, the first termAPᴴ X₀ D̄⁻¹is now also subject to thedegeneracy_atolstopping test instead of always being added.