Skip to content

Try to get the Mooncake & Enzyme tests to consistently pass - #293

Merged
kshyatt merged 5 commits into
mainfrom
ksh/moon_eig
Oct 6, 2026
Merged

kshyatt merged 5 commits into
mainfrom
ksh/moon_eig

Conversation

@kshyatt

@kshyatt kshyatt commented Oct 1, 2026

Copy link
Copy Markdown
Member

A couple test nits here:

  • The rng we setup wasn't actually being used
  • LAPACK sometimes reorders eigenvalues (sorting them) in a way that blows up FD
  • For the truncation tests, we were accidentally generating trunctols that were also not playing nicely with FD

Hopefully this gets Mooncake and buddies consistently back on the path of happiness.

Comment thread test/testsuite/ad_utils.jl Outdated
Comment thread test/testsuite/ad_utils.jl
@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from ksh/trunc_fwd to main October 3, 2026 20:17
@kshyatt
kshyatt requested a review from lkdvos October 6, 2026 07:21
@kshyatt kshyatt changed the title Try to get the Mooncake & friends tests to consistently pass Try to get the Mooncake & Enzyme tests to consistently pass Oct 6, 2026
@kshyatt
kshyatt merged commit 8ae1003 into main Oct 6, 2026
48 checks passed
@kshyatt
kshyatt deleted the ksh/moon_eig branch October 6, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants