Repository navigation

Make `svd_pullback!` and `eigh_pullback!` cost proportional to the number of cotangent columns - #292

Merged

leburgel merged 24 commits into

mainfrom

lb/full_pullback_kept_columns

Oct 8, 2026

Commits on Oct 7, 2026
- Make `svd_pullback!` and `eigh_pullback!` cost proportional to the number of cotangent columns
  leburgel
  committed
  7042c01
- Use `ind` variable name and clarify what is actually happening
  leburgel
  committed
  0e1c812
- Use consistent names for indices and parts withing the rank
  leburgel
  committed
  5c2af59
- Update src/pullbacks/eigh.jl
  
  leburgel
  and
  Jutho
  committed
  7078218
- Update src/pullbacks/eigh.jl
  
  leburgel
  and
  Jutho
  committed
  c0e3a58
- Update src/pullbacks/eigh.jl
  
  leburgel
  and
  Jutho
  committed
  9bd4199
- Update src/pullbacks/eigh.jl
  
  leburgel
  and
  Jutho
  committed
  d70931e
- Update src/pullbacks/svd.jl
  
  leburgel
  and
  Jutho
  committed
  9e7c6ac
- Use copies instead of views of the kept columns of U, Vᴴ and V
  leburgel
  committed
  80960b0
- Rename the kept-column factors in svd_pullback! to Sₖ, Uₖ and Vᴴₖ
  leburgel
  committed
  d075e95
- Use an explicit broadcast for the gauge check in check_and_prepare_svd_cotangents
  
  leburgel
  and
  Jutho
  committed
  9e00a00
- Clarify the column indices in check_and_prepare_svd_cotangents
  leburgel
  committed
  a3fcff1
- some changes for clarity and consistency
  
  Jutho
  authored and
  leburgel
  committed
  1f51d6c
- format fix
  
  Jutho
  authored and
  leburgel
  committed
  3701499
- fix typos
  
  Jutho
  authored and
  leburgel
  committed
  7248a5f
- Fix the remaining errors in the svd and eigh pullbacks
  leburgel
  committed
  a706ef2
- some more changes for GPU
  
  Jutho
  authored and
  leburgel
  committed
  94c65b8
- more fixes
  
  Jutho
  authored and
  leburgel
  committed
  820c23c
- more gpu view fixes
  
  Jutho
  authored and
  leburgel
  committed
  4d496d3
- one more gpu attempt
  
  Jutho
  authored and
  leburgel
  committed
  58c47eb
- Copy the selected singular values and ΔS entries instead of viewing them
  leburgel
  committed
  8051d01
- Remove unused variable
  leburgel
  committed
  97b3bce
- `k` -> `p` for number of kept columns, consistent with truncated pullbacks
  leburgel
  committed
  eef04e1
- Merge branch 'main' into lb/full_pullback_kept_columns
  leburgel
  authored
  8d4d059

Navigation Menu

Repository navigation

Make `svd_pullback!` and `eigh_pullback!` cost proportional to the number of cotangent columns - #292

Make `svd_pullback!` and `eigh_pullback!` cost proportional to the number of cotangent columns#292
leburgel merged 24 commits into
mainfrom
lb/full_pullback_kept_columns

Commits on Oct 7, 2026

Make `svd_pullback!` and `eigh_pullback!` cost proportional to the number of cotangent columns

Use `ind` variable name and clarify what is actually happening

Use consistent names for indices and parts withing the rank

Update src/pullbacks/eigh.jl

Update src/pullbacks/eigh.jl

Update src/pullbacks/eigh.jl

Update src/pullbacks/eigh.jl

Update src/pullbacks/svd.jl

Use copies instead of views of the kept columns of U, Vᴴ and V

Rename the kept-column factors in svd_pullback! to Sₖ, Uₖ and Vᴴₖ

Use an explicit broadcast for the gauge check in check_and_prepare_svd_cotangents

Clarify the column indices in check_and_prepare_svd_cotangents

some changes for clarity and consistency

format fix

fix typos

Fix the remaining errors in the svd and eigh pullbacks

some more changes for GPU

more fixes

more gpu view fixes

one more gpu attempt

Copy the selected singular values and ΔS entries instead of viewing them

Remove unused variable

`k` -> `p` for number of kept columns, consistent with truncated pullbacks

Merge branch 'main' into lb/full_pullback_kept_columns