Repository navigation
ci: keep build smoke's package downloads off a slow regional mirror - #253
Merged
Merged
Conversation
Core Checks' build smoke job installs its build dependencies, and the cross compilers, qemu and Clang that the ML-KEM build-policy test needs, on every run: about 240 MB. Hosted runners fetch packages from the Azure mirror of their own region first. In westus3 that mirror served packages at about 30 kB/s, while jobs of the same run in other regions fetched the same packages at 40 MB/s. Build smoke ran there on every attempt and reached its 45-minute limit before the build. apt moves to the next mirror only when a download fails, not when it is slow. - Try the main Ubuntu archive first, and keep the regional mirror as the last fallback. - Cache the downloaded packages between runs. apt reuses a cached package of the expected size without checking its hash, so only push runs save the cache, as with the ccache caches, and a pull request cannot change what another run installs. - Raise the limit to 90 minutes, so that a run that misses the cache can still finish on a slower mirror. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@codex review |
4 tasks done
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Reviewed at 2a8c92a: 0 findings shared privately with maintainers. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes what is blocking #233: Core Checks'
build smokejob has timed out on every attempt on its head,529e19f. Everything else in #233's CI passed.Cause. The job installs about 240 MB of packages on every run: its build dependencies, plus the cross compilers, qemu and Clang that the ML-KEM build-policy test needs (#225). Hosted runners fetch packages from the Azure mirror of their own region first. The westus3 mirror served packages at about 30 kB/s while other regions served the same packages at 40 MB/s:
1.x.xpush after #2521.x.x's job still passed because it has no toolchain install. apt moves to the next mirror only when a download fails, not when it is slow.Fix.
Tests run.
ci/checksall pass:test_classify_merge_profile(31 tests);test_ibd_timeout_wiring(7, 2 skipped);test_pq_merge_gate_contract(17);test_ci_pq_contract(29);test_merge_gate_poller(44).feature/pq-transportdon't run CI.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.