Repository navigation
ci: build pull request RPC docs from the event commit - #228
Merged
Merged
Conversation
The pull request build of the development RPC docs checked out refs/pull/<n>/merge and then required it to be the event's merge commit. That ref moves whenever the base branch or the pull request's stack changes, so a run that overlapped such a change checked out a different merge commit and failed "Validate version source checkout". Check out the event's merge commit by hash instead, as the release entries already do, and drop the now unused --development-checkout-ref plumbing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pull request build of the development RPC docs can fail at "Validate version source checkout" with no code problem. #225 hit it:
Checked out 967241a7…, expected 792c3c1e….refs/pull/<n>/merge, then requires it to be the event's merge commit (github.sha). GitHub moves that ref whenever the base branch or the pull request's stack changes. A run that overlaps such a change checks out a newer merge commit and fails.--development-checkout-refplumbing is removed from the workflow and fromdoc/rpc/versioned_site.py.Testing
python3 -m unittest discover -s test/rpc_docs(27 tests, 1 skipped because MkDocs isn't installed locally). The build-plan test now asserts that the development entry checks out its resolved commit.rpc-docs-pages.yml.Target Branch
1.x.x, the only branch with the versioned RPC docs workflow.Risk / Review Notes
Notes: CI only. Pushes to
main, releases and manual runs are unchanged; they already checked out by hash.Docs / Process Impact
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.