Add logs endpoint for swaps - logs.zebra-swaps.zsa-test.net#117
Open
seniakalma wants to merge 2 commits into
Open
Add logs endpoint for swaps - logs.zebra-swaps.zsa-test.net#117seniakalma wants to merge 2 commits into
seniakalma wants to merge 2 commits into
Conversation
PaulLaux
reviewed
May 7, 2026
PaulLaux
left a comment
There was a problem hiding this comment.
Looks good with one comment:
LOG_GROUP_NAME env var
- New lambda sets
LOG_GROUP_NAME = "/dev/ecs/zebra-swaps-task" - Existing
watch-zebra-logslambda (lambda/lambda/terragrunt.hcl) does not set this env var.
Looks like a potential conflict in the future, no?
Consider to set LOG_GROUP_NAME = "/dev/ecs/zebra-task" explicitly on the original, so no lambda relies on a default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lambda-swaps.watch-zebra-swaps-logs./dev/ecs/zebra-swaps-taskand expose it vialogs.zebra-swaps.zsa-test.net.