Issuance fixes and cleanup#249
Open
ConstanceBeguier wants to merge 8 commits into
Open
Conversation
When creating a new IssueNote, rho is set to None and rseed contains a temporary random value. Those values will be update when calling `update_rho`.
This function returns the x-coordinates (called cmx) of the note commitments and not the complete note commitments.
ConstanceBeguier
force-pushed
the
review_issuance
branch
from
29a6c94 to
3ab7815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves issuance correctness by tightening validation logic,
fixing edge cases, and clarifying IssueBundle APIs and documentation.
Main changes:
note_commitmentstonote_cmxs,API changes:
IssueBundle::new()now returnsResult<(IssueBundle<AwaitingNullifier>, AssetBase), Error>instead of
(IssueBundle<AwaitingNullifier>, AssetBase),IssueBundle::finalize_action()no longer returnsResult<(), Error>,IssueBundle::note_commitments()toIssueBundle::note_cmxs().