fix(solvers): probe the Xpress licence, run solving tests on licensed solvers - #995
Open
FabianHofmann wants to merge 3 commits into
Open
FabianHofmann wants to merge 3 commits into
FabianHofmann wants to merge 3 commits into
Conversation
Build cost — v1 vs legacyv1 build peak & time relative to legacy, on this commit — not a comparison against master (that is CodSpeed).
Full table (time + peak, mean)📊 Interactive plots + CSV: download the semantics-report-v1-vs-legacy artifact from this run. Report-only · not a gate · refreshed on every push · obsolete once legacy is dropped. |
Merging this PR will not alter performance
Comparing Footnotes
|
…es on available_solvers
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #994.
Note
The following content was generated by AI.
Changes proposed in this Pull Request
Xpress was the only solver without a licence probe, so
licensed_solverslisted it wheneverimport xpressworked. With a licence that does not cover the installed release (e.g. a licence for <= 9.4 with xpress 9.9.1 installed), every solver-parametrized test failed withxpress.InterfaceError.Xpress._license_probecallsxpress.init(). A rejected licence now shows up asok=Falseincheck_solver_licenses("xpress"), and Xpress drops out oflicensed_solvers.available_solversstill only checks the import and acquires no licence.to_xpress,to_gurobipy), now loop overlicensed_solversinstead ofavailable_solvers(18 files). Tests that only check installation, or raise before any solve, keepavailable_solvers.test_xpress_license_probe_failure_marks_unlicensed, mocking onlyxpress.init, like the existing probe tests.This also makes the
-k "not xpress"workaround unnecessary; it deselected every test with "expression" in its name.Verification (48828a2)
uv run mypy linopyreports 28 pre-existing errors inlinopy/solvers.pywhen xpress is installed (old-API fallback names, see #533); unchanged by this PR.Checklist
AGENTS.md).doc.doc/release_notes.rstof the upcoming release is included.