fix: preserve release result samples#122
Merged
Merged
Conversation
This was referenced Jul 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the PyAutoGalaxy workspace’s results guides quick-fit path to ensure release-profile validation produces the full, deterministic sample set expected by the tutorials that read indexed samples from disk.
Changes:
- Disable output sample weight-thresholding for the results quick-fit helper so the capped Nautilus run retains all samples needed by indexed-sample examples.
- In the release env-var profile, force
PYAUTO_TEST_MODE=0forguides/results/so results are written/read from the normaloutput/tree as expected by the guides. - Regenerate the corresponding results-guide notebook from the updated script.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/guides/results/_quick_fit.py | Disables samples_weight_threshold via conf.instance so the quick-fit retains all samples for downstream indexed-sample tutorials. |
| config/build/env_vars_release.yaml | Overrides PYAUTO_TEST_MODE to "0" for guides/results/ under the release-fidelity profile so outputs land in the normal output tree. |
| notebooks/guides/results/_quick_fit.ipynb | Regenerated notebook reflecting the quick-fit script change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run results guides outside test mode in the release profile, centralize results workflow setup through
_quick_fit.py, and retain all samples from the deliberately shallow quick fit so indexed sample tutorials remain deterministic.Scripts Changed
scripts/guides/results/_quick_fit.py— now creates two capped Nautilus fits in plainoutput/results_folder, retains all 300 samples, writes latent summaries, and disables fast-plot skipping so PNG/FITS workflow products exist.scripts/guides/results/workflow/{csv_make,png_make,fits_make}.py— reuse_quick_fit.pyinstead of duplicating their own two-fit setup; aggregate fromresults_folderinstead ofresults_folder_csv_png_fits.scripts/guides/results/aggregator/*— use plainPath("output") / "results_folder"; no workspace-side test-mode path handling.scripts/guides/results/start_here.py— useresults_folderfor the quick workflow output path.config/build/env_vars_release.yaml— unsetPYAUTO_TEST_MODEfor results guides so they run outside PyAuto test mode.Test Plan
start_here.pypasses with 300 retained samplessamples_via_aggregator.pypasses independently_quick_fit.pypasses withPYAUTO_TEST_MODEunset, 300 retained rows, and nooutput/test_mode/results_foldercsv_make.py,png_make.py,fits_make.pyreuse two centralized fits with latent summaries,fit.png, andfit.fitsunderoutput/results_folder; noresults_folder_csv_png_fitsis createdwith_test_mode_segment,PYAUTO_TEST_MODE, oroutput/test_modereferences remain inscripts/guides/results🤖 Generated with Codex