Skip to content

fix: preserve release result samples#122

Merged
Jammy2211 merged 4 commits into
mainfrom
feature/aggregator-output-contracts
Jul 7, 2026
Merged

fix: preserve release result samples#122
Jammy2211 merged 4 commits into
mainfrom
feature/aggregator-output-contracts

Conversation

@Jammy2211

@Jammy2211 Jammy2211 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Run results guides outside test mode in the release profile, centralize results workflow setup through _quick_fit.py, and retain all samples from the deliberately shallow quick fit so indexed sample tutorials remain deterministic.

Scripts Changed

  • scripts/guides/results/_quick_fit.py — now creates two capped Nautilus fits in plain output/results_folder, retains all 300 samples, writes latent summaries, and disables fast-plot skipping so PNG/FITS workflow products exist.
  • scripts/guides/results/workflow/{csv_make,png_make,fits_make}.py — reuse _quick_fit.py instead of duplicating their own two-fit setup; aggregate from results_folder instead of results_folder_csv_png_fits.
  • scripts/guides/results/aggregator/* — use plain Path("output") / "results_folder"; no workspace-side test-mode path handling.
  • scripts/guides/results/start_here.py — use results_folder for the quick workflow output path.
  • config/build/env_vars_release.yaml — unset PYAUTO_TEST_MODE for results guides so they run outside PyAuto test mode.
  • Corresponding notebooks and generated catalogues regenerated from scripts.

Test Plan

  • Clean release-profile start_here.py passes with 300 retained samples
  • samples_via_aggregator.py passes independently
  • Clean release-profile _quick_fit.py passes with PYAUTO_TEST_MODE unset, 300 retained rows, and no output/test_mode/results_folder
  • Clean release-profile workflow run passes: csv_make.py, png_make.py, fits_make.py reuse two centralized fits with latent summaries, fit.png, and fit.fits under output/results_folder; no results_folder_csv_png_fits is created
  • Focused workflow rerun confirms no with_test_mode_segment, PYAUTO_TEST_MODE, or output/test_mode references remain in scripts/guides/results
  • Workspace smoke tests: 8/8 passed

🤖 Generated with Codex

Copilot AI review requested due to automatic review settings July 6, 2026 20:39
@Jammy2211 Jammy2211 added the pending-release PR queued for the next release build label Jul 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PyAutoGalaxy workspace’s results guides quick-fit path to ensure release-profile validation produces the full, deterministic sample set expected by the tutorials that read indexed samples from disk.

Changes:

  • Disable output sample weight-thresholding for the results quick-fit helper so the capped Nautilus run retains all samples needed by indexed-sample examples.
  • In the release env-var profile, force PYAUTO_TEST_MODE=0 for guides/results/ so results are written/read from the normal output/ tree as expected by the guides.
  • Regenerate the corresponding results-guide notebook from the updated script.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
scripts/guides/results/_quick_fit.py Disables samples_weight_threshold via conf.instance so the quick-fit retains all samples for downstream indexed-sample tutorials.
config/build/env_vars_release.yaml Overrides PYAUTO_TEST_MODE to "0" for guides/results/ under the release-fidelity profile so outputs land in the normal output tree.
notebooks/guides/results/_quick_fit.ipynb Regenerated notebook reflecting the quick-fit script change.

@Jammy2211 Jammy2211 merged commit 3fcfc07 into main Jul 7, 2026
8 checks passed
@Jammy2211 Jammy2211 deleted the feature/aggregator-output-contracts branch July 8, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-release PR queued for the next release build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants