[bug] [draft] continuous action logprob precision mismatch#584
Draft
yacineMTB wants to merge 2 commits into
Draft
[bug] [draft] continuous action logprob precision mismatch#584yacineMTB wants to merge 2 commits into
yacineMTB wants to merge 2 commits into
Conversation
yacineMTB
commented
Jun 13, 2026
| float mean = to_float(a.logits[logits_base + h * a.logits_stride_a]); | ||
| float log_std = to_float(a.logstd[h]); | ||
| float action = float(g.actions[nt * a.num_atns + h]); | ||
| float action = to_float(g.actions[nt * a.num_atns + h]); |
yacineMTB
force-pushed
the
fix-continuous-action-logprob-4.0
branch
from
4dd4990 to
af45050
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still working on reproductions and baseline sweeps.
better one is post fix
Basically; if precision_t was bf16/fp16, the sampled fp32 action gets rounded, and that messes with things downstream in PPO.
discrete doesn't have this problem because it uses integers
This diff does improve things, tested in a sweep, but this code smells bad so I need to read it tomorrow morning. Draft