Skip to content

BYOC_ID: 46886 - Refactor Scottish Postcode Directory (SPD)#1340

Open
Jennit07 wants to merge 6 commits into
developmentfrom
refactor-spd
Open

BYOC_ID: 46886 - Refactor Scottish Postcode Directory (SPD)#1340
Jennit07 wants to merge 6 commits into
developmentfrom
refactor-spd

Conversation

@Jennit07

@Jennit07 Jennit07 commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary:

  • new get_spd_data() function
  • use new function in place of spd_path
  • Targets and dummy targets scripts updated

TODO:

  • confirm sdl tables
  • re-test code when the data is available in SDL

@Jennit07 Jennit07 added On hold Waiting for something / someone outside of our control BYOC 1a: Ready for Review 1 Refactoring completed by author (without data) 1: Preprod Data Not Available Denodo data not available in preprod labels Jun 16, 2026
Comment thread R/process_lookup_gpprac.R
"ca2018"
)
)
spd_file <- spd_data

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spd_file <- spd_data
spd_file <- spd_data %>%

@lizihao-anu lizihao-anu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment, and comments about reading files from Denodo for local files
#1336 (comment)

@LucyEmma22 LucyEmma22 removed the On hold Waiting for something / someone outside of our control label Jul 1, 2026
@lizihao-anu lizihao-anu added 2: Preprod Data in UAT Denodo data available in preprod and undergoing UAT 1b: Peer Review 1 Complete First peer review completed by reviewer (without data) and removed 1: Preprod Data Not Available Denodo data not available in preprod 1a: Ready for Review 1 Refactoring completed by author (without data) labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1b: Peer Review 1 Complete First peer review completed by reviewer (without data) 2: Preprod Data in UAT Denodo data available in preprod and undergoing UAT BYOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants