BYOC_ID: 46896 - Refactor gpprac lookup#1335
Open
OluwatobiOni wants to merge 2 commits into
Open
Conversation
OluwatobiOni
requested review from
Jennit07 and
lizihao-anu
and removed request for
lizihao-anu
June 5, 2026 15:26
OluwatobiOni
added
On hold
Jennit07
changed the title
Jennit07
reviewed
Jun 16, 2026
Comment on lines
43
to
45
| postcode = phsmethods::format_postcode(.data$postcode) | ||
| ) %>% | ||
| dplyr::distinct(.data$gpprac, .keep_all = TRUE) %>% |
Collaborator
There was a problem hiding this comment.
Do we also need these lines after line 15(denodo connection)?
Jennit07
reviewed
Jun 16, 2026
Comment on lines
+186
to
+192
| dplyr::select( | ||
| gpprac = "praccode", | ||
| pc7 = "postcode" | ||
| ) %>% | ||
| dplyr::mutate( | ||
| pc7 = phsmethods::format_postcode(.data$pc7, format = "pc7") | ||
| ) |
Collaborator
There was a problem hiding this comment.
Wondering if we also need this above after reading the denodo connection/table?
Jennit07
reviewed
Jun 16, 2026
Comment on lines
+25
to
+27
| gpprac_ref_file <- get_gpprac_ref_data(BYOC_MODE = BYOC_MODE) | ||
| open_data <- get_gpprac_opendata(BYOC_MODE = BYOC_MODE) | ||
| spd_file <- get_spd_data(BYOC_MODE = BYOC_MODE) %>% |
Collaborator
There was a problem hiding this comment.
Could we put all 3 of these into the parameters of the function please?
Jennit07
reviewed
Jun 16, 2026
Comment on lines
+25
to
+27
| gpprac_ref_file <- get_gpprac_ref_data(BYOC_MODE = BYOC_MODE) | ||
| open_data <- get_gpprac_opendata(BYOC_MODE = BYOC_MODE) | ||
| spd_file <- get_spd_data(BYOC_MODE = BYOC_MODE) %>% |
Collaborator
There was a problem hiding this comment.
Suggested change
| gpprac_ref_file <- get_gpprac_ref_data(BYOC_MODE = BYOC_MODE) | |
| open_data <- get_gpprac_opendata(BYOC_MODE = BYOC_MODE) | |
| spd_file <- get_spd_data(BYOC_MODE = BYOC_MODE) %>% | |
| gpprac_ref_file <- gpprac_ref_file | |
| gpprac_open_data <- gpprac_open_data | |
| spd_file <- spd_data %>% |
This is what the code would look like if those files were added into the functions parameter above
Collaborator
There was a problem hiding this comment.
suggested one rename here to make it a bit more clear what open data we are using
Jennit07
requested changes
Jun 16, 2026
Jennit07
left a comment
Jennit07
left a comment
Collaborator
There was a problem hiding this comment.
Hi @OluwatobiOni Overall the PR looks good, thanks for your hard work! I have a few minor suggestions. I'm happy to have another look/test again when the data is available to us! Thanks :)
Jennit07
added
ready for PHS testing
1b: Peer Review 1 Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO-DOs: