Skip to content

Get sdl helpers#1333

Open
OluwatobiOni wants to merge 18 commits into
developmentfrom
get-sdl-helpers
Open

Get sdl helpers#1333
OluwatobiOni wants to merge 18 commits into
developmentfrom
get-sdl-helpers

Conversation

@OluwatobiOni

Copy link
Copy Markdown
Collaborator

TODOs

LOCAL MODE (get_sdl_processed_data)

  • Verify all functions where BYOC_MODE was added in advance
  • Ensure underlying functions accept BYOC_MODE argument
  • Confirm paths still resolve correctly
  • Remove temporary comments once validated

RAW TABLE FUNCTION (get_sdl_raw_table_name)

  • Replace all dummy table names with actual Denodo tables

BOTH FUNCTIONS

  • Ensure dataset IDs are identical across both functions

@OluwatobiOni
OluwatobiOni requested a review from Jennit07 June 1, 2026 14:23
@Jennit07

Jennit07 commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Hi @OluwatobiOni this looks good - i need to test in R again. However the concept should work! I was also thinking that we could use the helper functions with those datasets we have already refactored in BYOC Mode e.g. get_sdl_raw_names("acute") to read the table names. We could update all of them on this branch!

@lizihao-anu
lizihao-anu self-requested a review June 16, 2026 09:09
Comment thread R/get_sdl_helpers.R Outdated
@lizihao-anu

Copy link
Copy Markdown
Collaborator

Can merge it first and keep building on this function in each individual PR.

Comment thread R/get_sdl_helpers.R Outdated
@lizihao-anu

Copy link
Copy Markdown
Collaborator

Hi @Jennit07 , could you have a review? Thanks

@Jennit07

Jennit07 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

From today's BYOC stand up (01/07/26) - LH to send code that can be used to pull the snapshot. This could be incorporated on this PR so that we just have to make a change in the one place for all datasets

extract_homelessness <- dplyr::tbl(
denodo_connect,
dbplyr::in_schema("sdl", "sdl_homelessness_source")
dbplyr::in_schema("sdl", get_sdl_raw_names("homelessness"))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dbplyr::in_schema("sdl", get_sdl_raw_names("homelessness"))
dbplyr::in_schema("sdl", get_sdl_dataset_names("homelessness"))

Discussed with Tobi - potentially we could change the name of this function to accommodate for the snapshot function?

We still need the distinction between raw names and processed names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants