BYOC_ID: 46056 Refactor District Nursing#1327
Open
LucyEmma22 wants to merge 19 commits into
Open
Conversation
…e-linkage-files into refactor-dn
LucyEmma22
commented
May 13, 2026
Jennit07
reviewed
May 20, 2026
Jennit07
reviewed
May 20, 2026
Jennit07
reviewed
May 20, 2026
4 tasks
Jennit07
reviewed
May 20, 2026
Jennit07
reviewed
May 20, 2026
Jennit07
reviewed
May 20, 2026
Jennit07
requested changes
May 20, 2026
Jennit07
left a comment
Collaborator
There was a problem hiding this comment.
Hi @LucyEmma22 Thanks for doing this PR - great work. Everything looks good, ive added some comments answering some of your code questions. A few changes required here. But overall looks good and i can test again when the data is ready! Thanks
| dn_costs_path <- get_file_path( | ||
| directory = fs::path(get_slf_dir(), "Costs"), | ||
| file_name = stringr::str_glue( | ||
| "Cost_DN_Lookup.parquet" |
Collaborator
There was a problem hiding this comment.
same comment as above
Collaborator
Author
There was a problem hiding this comment.
Should I keep the local file name the same for now or is that changing as well?
…log_slf_event, add write_to_disk argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data Required:
extract_district_nursing-->get_boxi_extract_path(year = year, type = "dn")dn_costs-->get_dn_raw_costs_path()dn_contacts-->fs::path(get_slf_dir(), "Costs", "DN-Contacts-Numbers-for-Costs.csv")population_lookup-->get_pop_path(type = "hscp")To Do/Check:
read_extract_district_nursing:get_dn_costs_path:get_ch_costs_path.process_costs_dn:costs_district_nursing.Rmd.get_dn_raw_costs_data/get_dn_contacts_data/get_hscp_pop_data:get_spd_data()(see BYOC_ID: 45966 Refactor sc demographics #1313).BYOC_MODE = TRUE) as whenBYOC_MODE = FALSE.get_dn_contacts_path:get_dn_raw_costs_path.log_slf_event:dn_cost_lookup,dn_contact_lookupandhscp_pop_lookupto type list.