Skip to content

BYOC_ID: 46056 Refactor District Nursing#1327

Open
LucyEmma22 wants to merge 19 commits into
developmentfrom
refactor-dn
Open

BYOC_ID: 46056 Refactor District Nursing#1327
LucyEmma22 wants to merge 19 commits into
developmentfrom
refactor-dn

Conversation

@LucyEmma22

@LucyEmma22 LucyEmma22 commented May 13, 2026

Copy link
Copy Markdown
Collaborator

Data Required:

  1. extract_district_nursing --> get_boxi_extract_path(year = year, type = "dn")
  2. dn_costs --> get_dn_raw_costs_path()
  3. dn_contacts --> fs::path(get_slf_dir(), "Costs", "DN-Contacts-Numbers-for-Costs.csv")
  4. population_lookup --> get_pop_path(type = "hscp")

To Do/Check:

  1. read_extract_district_nursing:
  • Check Denodo table name.
  • Check year column name.

  1. get_dn_costs_path:
  • Based on refactoring of get_ch_costs_path.

  1. process_costs_dn:
  • New function based on costs_district_nursing.Rmd.

  1. get_dn_raw_costs_data / get_dn_contacts_data / get_hscp_pop_data:
  • New functions based on refactoring of get_spd_data() (see BYOC_ID: 45966 Refactor sc demographics #1313).
  • Check Denodo table names.
  • Check Denodo column names and data types.
  • Check output is the same when BYOC_MODE = TRUE) as when BYOC_MODE = FALSE.
  • These functions could be added as targets?

  1. get_dn_contacts_path:
  • New function based on get_dn_raw_costs_path.
  • Returns local path.

  1. log_slf_event:
  • Added dn_cost_lookup, dn_contact_lookup and hscp_pop_lookup to type list.

@LucyEmma22 LucyEmma22 added On hold Waiting for something / someone outside of our control BYOC 1: Dependency Data Not Available Dependency data not available in preprod 1: Preprod Data Not Available Denodo data not available in preprod labels May 13, 2026
Comment thread R/process_costs_dn.R Outdated
Comment thread R/process_costs_dn.R Outdated
Comment thread R/process_costs_dn.R Outdated
Comment thread R/process_costs_dn.R Outdated
Comment thread R/read_extract_district_nursing.R Outdated
Comment thread SDL_process/dummy_targets.R
Comment thread _targets.R Outdated

@Jennit07 Jennit07 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LucyEmma22 Thanks for doing this PR - great work. Everything looks good, ive added some comments answering some of your code questions. A few changes required here. But overall looks good and i can test again when the data is ready! Thanks

@Jennit07 Jennit07 added ready for PHS testing 1b: Peer Review 1 Complete First peer review completed by reviewer (without data) labels May 20, 2026
Comment thread R/get_costs_paths.R Outdated
Comment thread R/get_costs_paths.R
dn_costs_path <- get_file_path(
directory = fs::path(get_slf_dir(), "Costs"),
file_name = stringr::str_glue(
"Cost_DN_Lookup.parquet"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I keep the local file name the same for now or is that changing as well?

Comment thread R/process_costs_dn.R Outdated
Comment thread R/process_costs_dn.R Outdated
@LucyEmma22 LucyEmma22 added 1b: Peer Review 1 Complete First peer review completed by reviewer (without data) On hold Waiting for something / someone outside of our control and removed On hold Waiting for something / someone outside of our control 1b: Peer Review 1 Complete First peer review completed by reviewer (without data) 1b: Ready for PHS Testing 1: Dependency Data Not Available Dependency data not available in preprod labels Jun 30, 2026
@LucyEmma22 LucyEmma22 added 2: Preprod Data in UAT Denodo data available in preprod and undergoing UAT 2: Dependency Data in UAT Dependency data available in preprod and undergoing UAT and removed On hold Waiting for something / someone outside of our control 1: Preprod Data Not Available Denodo data not available in preprod labels Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1b: Peer Review 1 Complete First peer review completed by reviewer (without data) 2: Dependency Data in UAT Dependency data available in preprod and undergoing UAT 2: Preprod Data in UAT Denodo data available in preprod and undergoing UAT BYOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants