refactor sc sds#1319
Open
OluwatobiOni wants to merge 10 commits into
Open
Conversation
This was referenced May 1, 2026
OluwatobiOni
added
On hold
Jennit07
reviewed
May 6, 2026
| write_to_disk = TRUE | ||
| ) { | ||
| process_sc_all_sds <- function(data, | ||
| sc_demog_lookup = read_file(get_sc_demog_lookup_path(BYOC_MODE = BYOC_MODE), BYOC_MODE = BYOC_MODE), |
Collaborator
There was a problem hiding this comment.
Does read_file contain the BYOC_MODE? Just wondering if this line should look like this as i have this on the demographics PR. But i could have missed it. Thanks
Suggested change
| sc_demog_lookup = read_file(get_sc_demog_lookup_path(BYOC_MODE = BYOC_MODE), BYOC_MODE = BYOC_MODE), | |
| sc_demog_lookup = read_file(get_sc_demog_lookup_path(BYOC_MODE = BYOC_MODE)), |
Collaborator
|
Reviewed 06/05/26 - just one comment from me but ready to test this when we have the data available |
Jennit07
added
1b: Peer Review 1 Complete
|
This Pull Request is stale because it has been at least 30 days with no activity. It will be closed if there is no activity within 7 days. |
Collaborator
Author
|
Wait for dependency, data not available. |
Collaborator
|
See this comment for |
OluwatobiOni
removed
On hold
OluwatobiOni
added
1a: Ready for Review 1
OluwatobiOni
marked this pull request as ready for review
June 29, 2026 17:04
Jennit07
added
1b: Peer Review 1 Complete
LucyEmma22
added
2: Preprod Data in UAT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR complete. (29/06 Edit)