Skip to content

BYOC_ID: 46080 Refactor SC Client#1314

Open
LucyEmma22 wants to merge 15 commits into
developmentfrom
refactor-sc-client
Open

BYOC_ID: 46080 Refactor SC Client#1314
LucyEmma22 wants to merge 15 commits into
developmentfrom
refactor-sc-client

Conversation

@LucyEmma22

@LucyEmma22 LucyEmma22 commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Complete and reviewed. Waiting for SC Client and SC Demographics data.

To-Do:

  • Check SDL table names
  • Check that there are still 2 separate tables in the SDL view (one by year and one by quarter)
  • Test locally

LucyEmma22
LucyEmma22 commented Apr 29, 2026
View reviewed changes
Comment thread R/read_lookup_sc_client.R
} else {
client_data <- client_data
}

@LucyEmma22 LucyEmma22 Apr 29, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed intermediate saving. See comment in #1313

@LucyEmma22

LucyEmma22 commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Notes:

  • Data not yet available
  • Check SDL table names
  • Check that there are still 2 separate tables in the SDL view (one by year and one by quarter)
  • Dependency: sc_demog_lookup (output by process_lookup_sc_demographics())

@LucyEmma22 LucyEmma22 added On hold Waiting for something / someone outside of our control BYOC 1: Dependency Data Not Available Dependency data not available in preprod 1a: Ready for Review 1 Refactoring completed by author (without data) labels Apr 30, 2026
@LucyEmma22
LucyEmma22 requested a review from OluwatobiOni May 6, 2026 08:47
@Jennit07

Jennit07 commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Notes:

  • Data not yet available
  • Check SDL table names
  • Check that there are still 2 separate tables in the SDL view (one by year and one by quarter)
  • Refactor get_sc_client_lookup_path() in get_sc_lookup_paths.R
  • Dependency: sc_demog_lookup (output by process_lookup_sc_demographics())

Notes:

  • Data not yet available
  • Check SDL table names
  • Check that there are still 2 separate tables in the SDL view (one by year and one by quarter)
  • Refactor get_sc_client_lookup_path() in get_sc_lookup_paths.R
  • Dependency: sc_demog_lookup (output by process_lookup_sc_demographics())

for get_sc_client_lookup_path please see #1313 for how i refactored get_sc_demog_lookup_path() as this might work similar

Jennit07
Jennit07 reviewed May 11, 2026
View reviewed changes
Comment thread R/get_sc_lookup_paths.R Outdated
LucyEmma22 and others added 3 commits May 11, 2026 10:23
@Jennit07 Jennit07 added the 1: Preprod Data Not Available Denodo data not available in preprod label May 11, 2026
@OluwatobiOni OluwatobiOni removed the 1a: Ready for Review 1 Refactoring completed by author (without data) label May 13, 2026
@OluwatobiOni

OluwatobiOni commented May 18, 2026

Copy link
Copy Markdown
Collaborator

PR code looks good. Awaiting data for testing.

@AghimienI AghimienI added the 1b: Peer Review 1 Complete First peer review completed by reviewer (without data) label May 27, 2026
@LucyEmma22 LucyEmma22 removed On hold Waiting for something / someone outside of our control ready for PHS testing labels Jun 30, 2026
@LucyEmma22 LucyEmma22 added ready for PHS testing 1b: Peer Review 1 Complete First peer review completed by reviewer (without data) On hold Waiting for something / someone outside of our control and removed 1b: Peer Review 1 Complete First peer review completed by reviewer (without data) 1b: Ready for PHS Testing 1: Dependency Data Not Available Dependency data not available in preprod labels Jun 30, 2026
LucyEmma22
LucyEmma22 commented Jul 16, 2026
View reviewed changes
Comment thread R/process_lookup_sc_client.R Outdated
year,
sc_demographics = read_file(get_sc_demog_lookup_path()) %>%
sc_demographics = read_file(get_sc_demog_lookup_path(BYOC_MODE = BYOC_MODE)) %>%
dplyr::select(c("sending_location", "social_care_id", "anon_chi", "extract_date", "consistent_quality")),

@LucyEmma22 LucyEmma22 Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I move this selection into the function body?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jennit07 Jennit07 Jennit07 left review comments
@OluwatobiOni OluwatobiOni Awaiting requested review from OluwatobiOni

At least 1 approving review is required to merge this pull request.

Assignees

@OluwatobiOni OluwatobiOni

Labels

1b: Peer Review 1 Complete First peer review completed by reviewer (without data) 1: Preprod Data Not Available Denodo data not available in preprod BYOC On hold Waiting for something / someone outside of our control

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LucyEmma22 @Jennit07 @OluwatobiOni @AghimienI