BYOC_ID: 40072 refactor-acute#1283
Conversation
|
Dependency missing: Acute CUP file |
Jennit07
added
On hold
There was a problem hiding this comment.
I'm getting the following error on this line:
Error in `dplyr::mutate()`:
ℹ In argument: `month_name = month_order[.data$costmonthnum]`.
Caused by error:
! `month_name` must be size 100 or 1, not 0.
Run `rlang::last_trace()` to see where the error occurred.
Called from: signal_abort(cnd, .file)
We think this is due to costmonthnum being an integer64 variable but UAT tests show this should be numeric. This has been flagged and should be updated in the next round of UAT feedback
There was a problem hiding this comment.
I think it happened in refactoring some dataset before. I will have a look at get back to suggest changes to make it consistent.
Jennit07
removed
the
1a: Ready for Review 1
|
I have reviewed this PR and it looks good! there is an error i am getting which i have commented above. This should be corrected in the next round of UAT feedback. Waiting on:
This will be ready for BYOC testing once the two issues are addressed. |
OluwatobiOni
added
the
1a: Ready for Review 1
Jennit07
added
2: Preprod Data in UAT
Co-authored-by: Jennifer Thom <67372904+Jennit07@users.noreply.github.com>
LucyEmma22
added
On hold
| c_year <- convert_fyyear_to_year(year) | ||
|
|
||
| # Specify years available for running | ||
| if (!check_year_valid(year, type = "acute_cup")) { |
There was a problem hiding this comment.
are we updating check_year_valid to include acute_cup? Otherwise, we can just use "acute" as the type here since it is dependent on acute anyway. @LucyEmma22
There was a problem hiding this comment.
Ooh that's a good spot. Maybe I'll add it to the check_year_valid type list for consistency?
There was a problem hiding this comment.
Or should we just remove this check since we weren't previously checking valid years for the CUP files? @Jennit07
LucyEmma22
added
On hold
4 participants
No description provided.