Circuit processing#133
Conversation
koalamitice
left a comment
koalamitice
left a comment
There was a problem hiding this comment.
Most of the code looks good! I made some comments. Feel free to ask questions if I did not explain them well enough :)
|
General comment: The test cases in this PR currently fail because of Python Dependency issues with existing solvers. This PR therefore depends on the finalization of #132 , which fixes this issues by adding a virtual environemnt for every Python solver. |
|
|
ekulos-code
force-pushed
the
circuit-processing
branch
from
0ca1d22 to
c461dfe
Compare
Elscrux
left a comment
Elscrux
left a comment
There was a problem hiding this comment.
This looks really polished already, great job! Please let me know what do you think are the things that are not really clear right now.
|
|
|
Thanks for resolving everything, to me this looks pretty good now. The remaining steps to take seem to be:
|
Merge circuit execution files
ekulos-code
force-pushed
the
circuit-processing
branch
from
8539c31 to
431f503
Compare
|
3 participants
Add circuit execution and optimization