Remove unneeded nesting in the ExcerptData and SeoData#7
Merged
alexander-schranz merged 2 commits intoNov 21, 2025
Conversation
alexander-schranz
force-pushed
the
enhancement/seo-dynamic-data-flatten
branch
2 times, most recently
from
4586410 to
735ed89
Compare
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
enhancement/seo-dynamic-data-flatten
branch
3 times, most recently
from
666a350 to
24893f9
Compare
1 task
alexander-schranz
force-pushed
the
enhancement/seo-dynamic-data-flatten
branch
4 times, most recently
from
0427e1a to
e4bfd2e
Compare
alexander-schranz
force-pushed
the
enhancement/seo-dynamic-data-flatten
branch
from
e4bfd2e to
6bb098f
Compare
alexander-schranz
force-pushed
the
enhancement/seo-dynamic-data-flatten
branch
from
8e20f40 to
0bf1b77
Compare
|
|
||
| public function testMapWithInvalidExcerptProperty(): void | ||
| { | ||
| $this->markTestSkipped('TODO: we should implement this as soon as we implemented also unlocalized properties.'); |
Author
There was a problem hiding this comment.
Like the test but currently skipped we should add something similar we do for templateMetadata to write the properties in localized and unlocalized correctly:
alexander-schranz
merged commit 0bf1b77
into
Prokyonn:enhancement/seo-dynamic-data
8 checks passed
Prokyonn
added a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue of: sulu#8383
The
excerptDatashould not include the array with keyexcerptandseoDatanot key withseo.So its
$dimensionContent->setExcerptData(['title' => 'Excerpt Title')]);