Conversation
📊 Coverage Report |
There was a problem hiding this comment.
Pull request overview
This PR updates note validation to be octave-insensitive (aligning individual note validation with existing chord validation behavior) and adjusts logging output to avoid using std::println with file streams.
Changes:
- Make
AnswerValidator::validerignore octave when comparing single notes. - Extend unit tests to cover matching notes across different octaves.
- Write log lines to files using
std::format+ stream insertion instead ofstd::println(file, ...).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/AnswerValidator.cpp |
Strips trailing octave digit and normalizes case before comparing notes. |
test/AnswerValidatorTest.cpp |
Adds assertions for octave-insensitive single-note validation. |
include/Logger.hpp |
Switches file logging to file << std::format(...) for compatibility. |
test/ChallengeFactoryTest.cpp |
Minor formatting/indentation adjustment in the test. |
Comment on lines
+22
to
+23
| std::transform(n1.begin(), n1.end(), n1.begin(), ::toupper); | ||
| std::transform(n2.begin(), n2.end(), n2.begin(), ::toupper); |
Comment on lines
6
to
+10
| /// Compare notes jouées vs attendues (égalité stricte) | ||
| TEST_CASE("AnswerValidator::valider") { | ||
| AnswerValidator vn; | ||
| CHECK(vn.valider("c4", "c4")); | ||
| CHECK(vn.valider("c4", "c3")); // Différentes octaves |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.