chore(workspace): bump mocha v12 for esm config file#1626
Draft
thescientist13 wants to merge 1 commit into
Draft
chore(workspace): bump mocha v12 for esm config file#1626thescientist13 wants to merge 1 commit into
thescientist13 wants to merge 1 commit into
Conversation
Member
Author
|
Yeah, some of these changes in the import map snapshot seem expected, just that packages do funny things. For instance, why would chokidar be in an import map? ➜ greenwood git:(master) ✗ yarn why chokidar
yarn why v1.22.22
[1/4] 🤔 Why do we have the module "chokidar"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "chokidar@3.5.2"
info Reasons this module exists
- "_project_#mocha" depends on it
- Hoisted from "_project_#mocha#chokidar"
info Disk size without dependencies: "136KB"
info Disk size with unique dependencies: "356KB"
info Disk size with transitive dependencies: "680KB"
info Number of shared dependencies: 13
=> Found "netlify-cli#chokidar@3.5.3"
info This module exists because "_project_#@greenwood#plugin-adapter-netlify#netlify-cli" depends on it.
info Disk size without dependencies: "108KB"
info Disk size with unique dependencies: "328KB"
info Disk size with transitive dependencies: "652KB"
info Number of shared dependencies: 13
=> Found "livereload#chokidar@3.4.2"
info This module exists because "_project_#@greenwood#cli#livereload" depends on it.
info Disk size without dependencies: "108KB"
info Disk size with unique dependencies: "328KB"
info Disk size with transitive dependencies: "652KB"
info Number of shared dependencies: 13
=> Found "sass#chokidar@4.0.1"
info This module exists because "_project_#@greenwood#cli#@uswds#web-components#sass" depends on it.
info Disk size without dependencies: "304KB"
info Disk size with unique dependencies: "336KB"
info Disk size with transitive dependencies: "452KB"
info Number of shared dependencies: 2
✨ Done in 0.63s.Which leads us to see why SASS is there... ➜ greenwood git:(master) ✗ yarn why sass
yarn why v1.22.22
[1/4] 🤔 Why do we have the module "sass"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "sass@1.81.0"
info Reasons this module exists
- "_project_#@greenwood#cli#@uswds#web-components" depends on it
- Hoisted from "_project_#@greenwood#cli#@uswds#web-components#sass"
info Disk size without dependencies: "6.05MB"
info Disk size with unique dependencies: "7.04MB"
info Disk size with transitive dependencies: "7.57MB"
info Number of shared dependencies: 16
✨ Done in 1.27s.And there's your answer, it's pulled in through USWDS. My guess is the rest are like this as well, and at least in this case, they are being deleted. |
Member
Author
|
OK, so the test failure issue (which we also see in #1595 ) seems to be a mocha issue after all, related to this issue - mochajs/mocha#4785 (comment) |
9 tasks
3d0504e to
55a7f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Mocha will soon start supporting an ESM based configuration file - https://github.com/mochajs/mocha/releases/tag/v12.0.0-beta-4
Documentation
N / A
Summary of Changes
TODO