Conversation
Pin the public candidate-collection rename and update terminology. Preserve dependency versions and sketchlib revisions; backend calls already infer the renamed return type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
marked this pull request as ready for review
September 30, 2026 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #809. Uses ProjectASAP/ASAPPlanner#508.
Why
The Planner candidate collection is now named
CandidatePostASAPDAGs, matching the architecture terminology.What
Pin Planner revision
ea12b31680be777b1866d3ea5fc82fd4a9a3e57eand update backend comments and documentation. Only Planner revision entries change in Cargo.lock; every dependency version and sketchlib revision is preserved. Backend call sites already infer the collection's type, so no execution code change is needed.Before this PR
The backend pins the old
PlanSpaceAPI.After this PR
The backend compiles against
CandidatePostASAPDAGswith the same search, selection, and runtime behavior.Validation
Formatting, whitespace checks, workspace all-target Clippy with warnings denied, and the complete control-plane test suite passed against the exact renamed API revision. Planner workspace tests also passed; its Rust diff is naming and formatting only.
🤖 Generated with Claude Code