Conversation
This was referenced Oct 4, 2026
…asap-aware-mapping Move asap-aware-mapping's pass/ (OptimizationPass, StagePipeline, PassRegistry, optimize) into crates/planner, the facade per #572, and remove the now-empty asap-aware-mapping crate from the workspace. PlanningModels is re-exported by the planner from asap-plan-selection. The stage manifest guards now name asap-planner instead of the deleted crate. Docs and comments that cited asap-aware-mapping as a crate now name the stage crate that owns the code (#572, B4b). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zzylol
force-pushed
the
stack/572-b4b-planner-facade
branch
from
October 5, 2026 06:21
999fd95 to
9ccef96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on main d4869a7 (DF 54).
Why
#572 makes
crates/plannerthe facade that runs Stages 0–3 and retiresasap-aware-mapping. After B2–B4,asap-aware-mappingholds only thepass/facade (OptimizationPass,StagePipeline,PassRegistry,optimize). This PR (step B4b) moves it intoasap-plannerand deletes the crate. It is a pure move.What
Before this PR
After this PR
cargo tree -p asap-planner --depth 1 -e normal,dev:Consequence: a third-party pass (#430) now implements
asap_planner::OptimizationPass, so it depends on the front ends, including DataFusion. Before, it could depend onasap-aware-mappingalone. This follows #572's layout ("planner/: facade … absorbs today's pass/ MajorPass driver"). If a frontend-free pass API is wanted, that is a separate design decision.How
git mvasap-aware-mapping/src/pass/{mod, stage_pipeline}.rstoplanner/src/pass/with no changes, and deleteasap-aware-mapping'sCargo.tomlandlib.rs. The crate is removed from the workspace.asap-plannerdeclarespub mod passand re-exports the same root namesasap-aware-mappinghad:optimize,OptimizationInput,OptimizationInputError,OptimizationPass,OptimizeError,PassNameConflict,PassRegistry,PlanOutput,QueryPlanandStagePipeline, plusPlanningModelsfromasap_plan_selection. It now depends onasap-logical-optimizer(normal, used bystage_pipeline) instead of as a dev-dependency.asap-planneritself (lib and two tests) still importedasap_aware_mapping. Those imports now useasap_planner::pass::….asap-plannerinstead of the deleted crate.asap-aware-mappingas the owner of code now name the owning crate: the architecture crate table, the pluggable-interface code layout and diagram,accuracy-models,cse-cost-model,concat-unique-keys,library-api(dependency list, cost-model path base,cargo doc),pre-asap-ir, thecargo test -pcommands inphysical-handoff-costsandstorage-operation-costs, and comments inasap-types::dag_export,logical-optimizer,integration-tests/cse.rs, devtools and a frontend-promql test.Still mentions
asap-aware-mapping/asap_aware_mapping(intentionally)docs/develop_docs/asap-aware-mapping-{architecture,contracts}.md,extend-asap-aware-mapping.md,docs/design_docs/{architecture,concepts}/asap-aware-mapping.mdanddocs/design_docs/proposals/asap-aware-mapping/with every link to them. Renaming documents is out of scope for a code move.planner-vocabulary-migration.md:26(migration table) and the ERP proposal's note thatasap-aware-mapping::erpwas deleted.logical-optimizerpass1/{replacement, rewrite, rollup}.rscitedocs/design_docs/asap_aware_mapping.md/docs/asap_aware_mapping.md, which no longer exist.tools/dag-viewer/README.md:167links to a missingdocs/design_docs/asap-aware-mapping/analytical-resource-cost.md.tools/dag-viewer/dag.example.jsonhas rationale strings namingasap_aware_mapping::replacement(andasap_types::post_asap) from an old export.Cargo.lockno longer lists it.Moved files
asap-aware-mapping/src/pass/mod.rsplanner/src/pass/mod.rs(unchanged)asap-aware-mapping/src/pass/stage_pipeline.rsplanner/src/pass/stage_pipeline.rs(unchanged)asap-aware-mapping/{Cargo.toml, src/lib.rs}Volume
30 files changed, +54 / −115. 2 files moved, 2 deleted; 11 doc files and comments in 6 source files updated.
Gate (at the tip)
cargo fmt --all --check: passes.cargo clippy --workspace --all-targets --all-features -- -D warnings: passes.cargo test --workspace: 1,508 passed, 12 ignored, the same as B4. No test is added or deleted. Compared with refactor: extract the Stage 1 logical-optimizer crate (#572 B2) #583 (1,528), see refactor(planner): extract the Stage 3 plan-selection crate #585.python3 -m unittest discover -s tools/dag-viewer -p test_render.py: OK, 6 skipped.stage_pipeline --example planner-layering-1regeneratestools/dag-viewer/examples/planner-layering-example1.jsonbyte for byte.Part of #572 (B4b) and #509. Follows #585. Related: #580. Next: B5 (
asap-executor).🤖 Generated with Claude Code