Skip to content

feat: implement filters for single district#255

Open
Log234 wants to merge 1 commit into
developmentfrom
feature/filters-for-single-district
Open

feat: implement filters for single district#255
Log234 wants to merge 1 commit into
developmentfrom
feature/filters-for-single-district

Conversation

@Log234

@Log234 Log234 commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

Description

Adds filters to the Single District view.

Issues closed

Closes #252

@Log234 Log234 added enhancement New feature or request feature labels Aug 28, 2020
@Log234 Log234 added this to the Main Release milestone Aug 28, 2020
@Log234 Log234 requested a review from simendag August 28, 2020 09:34
@Log234 Log234 self-assigned this Aug 28, 2020
@cypress

cypress Bot commented Aug 28, 2020

Copy link
Copy Markdown



Test summary

827 0 0 0


Run details

Project Lavinia-client
Status Passed
Commit 14a19db
Started Aug 28, 2020 9:35 AM
Ended Aug 28, 2020 10:17 AM
Duration 42:32 💡
OS Linux Ubuntu Linux - 16.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress

cypress Bot commented Aug 28, 2020

Copy link
Copy Markdown



Test summary

827 0 0 0


Run details

Project Lavinia-client
Status Passed
Commit afa6922 ℹ️
Started Aug 28, 2020 9:36 AM
Ended Aug 28, 2020 10:19 AM
Duration 43:08 💡
OS Linux Ubuntu Linux - 16.04
Browser Electron 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@simendag

simendag commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

I suggest we put this PR on hold until we can resolve #254

We might even fix it in this PR.

import { checkExhaustively } from "../../../utilities";
import { DistrictSelect } from "./DistrictSelect";
import { norwegian } from "../../../utilities/rt";
import { norwegian, caseInsensitiveFilterMethod, selectFilterWithOptions, thresholdOptions, thresholdFilterMethod, eqOrNeqZeroOptions, allGreaterThanEqualsMethod, positiveOrNegativeFilterMethod } from "../../../utilities/rt";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really should be on more than one line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: add filters to Single District

2 participants