Accordion Hero Widget#2
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restructures the repository from a single-widget project to a multi-widget collection framework. It updates documentation and build processes to reflect this new architecture, while maintaining the existing accordion-hero-slider as the first widget in the collection.
Key Changes:
- Repositioned as a "Custom Elementor Widgets Repository" rather than a single plugin repository
- Streamlined build process to create only versioned ZIP files, removing intermediate unversioned artifacts
- Updated GitHub Actions dependencies to latest versions (v3→v4 for checkout and upload-artifact, v1→v2 for gh-release)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Rebranded from single plugin to multi-widget repository with updated documentation |
| build-zip.sh | Simplified to create only versioned ZIPs and removed intermediate build artifacts |
| .github/workflows/build-and-release.yml | Updated action versions and streamlined ZIP creation workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -22,31 +22,26 @@ jobs: | |||
| echo "VERSION=$VERSION" >> $GITHUB_ENV | |||
| echo "::set-output name=version::$VERSION" | |||
There was a problem hiding this comment.
The set-output command is deprecated in GitHub Actions. This command was deprecated in favor of environment files and will cause warnings or failures in future GitHub Actions runners. Use $GITHUB_OUTPUT instead of set-output.
| echo "::set-output name=version::$VERSION" | |
| echo "version=$VERSION" >> $GITHUB_OUTPUT |
| run: | | ||
| mkdir -p releases | ||
| zip -r releases/accordion-hero-slider.zip accordion-hero-slider -x "*.DS_Store*" "*.git*" | ||
| zip -r releases/accordion-hero-slider-v${{ env.VERSION }}.zip accordion-hero-slider -x "*.DS_Store*" "*.git*" |
There was a problem hiding this comment.
The removal of the README.md exclusion from the zip command means the repository's main README.md will now be included in the plugin ZIP file, which could be confusing for end users. The previous version correctly excluded it with "*/README.md" to prevent including unwanted documentation files.
| zip -r releases/accordion-hero-slider-v${{ env.VERSION }}.zip accordion-hero-slider -x "*.DS_Store*" "*.git*" | |
| zip -r releases/accordion-hero-slider-v${{ env.VERSION }}.zip accordion-hero-slider -x "*.DS_Store*" "*.git*" "*/README.md" |
| ### GitHub Actions | ||
| - **PR Build**: Every Pull Request automatically generates a versioned ZIP file for testing. | ||
| - **Release**: Merging to `main` (or pushing a tag) will automatically create a new GitHub Release with the plugin ZIP attached. | ||
| - **PR Build**: Every Pull Request automatically generates versioned ZIP files for the modified widgets. |
There was a problem hiding this comment.
The documentation states that every Pull Request generates "versioned ZIP files for the modified widgets" (plural), but the build process only creates a single ZIP file for the accordion-hero-slider widget. This is misleading as it suggests multiple widgets are built when only one is actually processed.
| - **PR Build**: Every Pull Request automatically generates versioned ZIP files for the modified widgets. | |
| - **PR Build**: Every Pull Request automatically generates a versioned ZIP file for the modified `accordion-hero-slider` widget. |
|
|
||
| # Create a versioned copy | ||
| cp $OUTPUT_DIR/$ZIP_NAME $OUTPUT_DIR/$VERSIONED_ZIP_NAME | ||
| zip -r $OUTPUT_DIR/$VERSIONED_ZIP_NAME $PLUGIN_DIR -x "*.DS_Store*" "*.git*" |
There was a problem hiding this comment.
The removal of the README.md exclusion from the zip command means the repository's main README.md will now be included in the plugin ZIP file, which could be confusing for end users. The previous version correctly excluded it with "*/README.md" to prevent including unwanted documentation files.
No description provided.