Skip to content
This repository was archived by the owner on May 15, 2023. It is now read-only.

fixed issue #56 - invalid property does not update#57

Open
ahmedelkilani wants to merge 1 commit into
PolymerElements:masterfrom
ahmedelkilani:fix-issue-56
Open

fixed issue #56 - invalid property does not update#57
ahmedelkilani wants to merge 1 commit into
PolymerElements:masterfrom
ahmedelkilani:fix-issue-56

Conversation

@ahmedelkilani

@ahmedelkilani ahmedelkilani commented Mar 22, 2017

Copy link
Copy Markdown

Fixed issue #56 . invalid property is not updated even after calling validate method.

@mcrowder65

Copy link
Copy Markdown

Could we get this merged?

@TomK

TomK commented Oct 25, 2017

Copy link
Copy Markdown

Potentially this is not the correct approach.
IronValidatableBehavior states custom validation should override the method _getValidity and not validate.

Both these solutions fix the issue, but potentially overriding _getValidity is more correct based on documentation.

@arthurevans @e111077 can one of you point this in the right direction?

@e111077

e111077 commented Oct 25, 2017

Copy link
Copy Markdown
Contributor

requesting the summon of the queen of inputs and validation @notwaldorf

@notwaldorf

Copy link
Copy Markdown
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants