This repository was archived by the owner on May 15, 2023. It is now read-only.
fixed issue #56 - invalid property does not update#57
Open
ahmedelkilani wants to merge 1 commit into
Open
Conversation
b64453b to
06f1b76
Compare
|
Could we get this merged? |
|
Potentially this is not the correct approach. Both these solutions fix the issue, but potentially overriding @arthurevans @e111077 can one of you point this in the right direction? |
Contributor
|
requesting the summon of the queen of inputs and validation @notwaldorf |
Contributor
|
It seems in other elements we do both? https://github.com/PolymerElements/gold-cc-cvc-input/blob/master/gold-cc-cvc-input.html#L313 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #56 . invalid property is not updated even after calling validate method.