Merge branch 'main' of github.com:PlummersSoftwareLLC/NightDriverStrip#899
Open
davepl wants to merge 3 commits into
Open
Merge branch 'main' of github.com:PlummersSoftwareLLC/NightDriverStrip#899davepl wants to merge 3 commits into
davepl wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Stocks (matrix) effect to fetch and display live quote data using the newer v2 stock API payloads, and adds a Debug CLI command to manually refresh/print quotes. It also refines the web installer wizard’s step navigation UX.
Changes:
- Update
PatternStocksto request and parse v2 quote payloads (including compact v2 format), and adjust display logic accordingly. - Add a
quotesDebug CLI command to refresh and print stock quote data. - Improve installer wizard step navigation (clickable walked steps, locked steps, ARIA/disabled handling), plus minor styling adjustments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/formatsize.cpp | Changes size formatting behavior (precision handling). |
| src/debug_cli.cpp | Adds a quotes CLI command that refreshes and prints stock quotes. |
| include/effects/matrix/PatternStocks.h | Switches stock fetching to v2 API, adds parsing helpers and quote refresh helpers, updates rendering logic. |
| config/installer_index.html | Updates wizard step UI to buttons with walked/locked navigation and related event handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the stock server to show the correct, live data, and uses the new V2 api to fetch it.
mainas the target branch.