schedule and robustness#103
Open
robertlipe wants to merge 6 commits into
Open
Conversation
- Fixed Schedule logic to correctly handle time ranges crossing midnight. - Updated Canvas and Controller deserialization to handle missing optional fields. - Switched Canvas feature mutex to recursive_mutex to prevent deadlocks.
Collaborator
|
See comment on #101. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a night owl. My test case (and my common playtime) spans
midnight. The original code was unhappy with effects spanning
midnight and if the app was started after midnight, wouldn't pick
up an effect that should have been started.
In interrupt parlance, I changed from edge triggered to level-triggered.
Fixed deadlocks when schedules overlapped.
Fixed crashed in JSON parser for missing fields.