Conversation
Collaborator
|
CI consistently fails on this, because 7 out of 11 tests fail. I'm guessing the tests need an update? |
rbergen
requested changes
Jun 9, 2026
rbergen
left a comment
rbergen
left a comment
Collaborator
There was a problem hiding this comment.
As indicated in an earlier comment, CI fails due to failing tests. Please apply necessary fixes to make the full test suite pass again.
rbergen
approved these changes
Jun 9, 2026
rbergen
left a comment
rbergen
left a comment
Collaborator
There was a problem hiding this comment.
Test suite extended and passes. LGTM now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI itself is AI generated, as are the integration hooks and new CROW routes, etc. I have not carefully reviewed the UI code itself, only tested it fairly completely.