Conversation
Contributor
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 3.54 % | 3.995e+03 | 4.137e+03 | 141.26 | 31.14 | 29.84 |
test_proximal_jac_w7x_with_eq_update | -1.73 % | 6.610e+03 | 6.496e+03 | -114.11 | 153.40 | 152.25 |
test_proximal_freeb_jac | -0.25 % | 1.336e+04 | 1.333e+04 | -33.24 | 84.14 | 82.15 |
test_proximal_freeb_jac_blocked | 0.57 % | 7.601e+03 | 7.644e+03 | 43.02 | 71.21 | 69.30 |
test_proximal_freeb_jac_batched | 0.83 % | 7.579e+03 | 7.641e+03 | 62.82 | 70.30 | 67.56 |
test_proximal_jac_ripple | 3.02 % | 3.498e+03 | 3.604e+03 | 105.64 | 55.58 | 53.05 |
test_proximal_jac_ripple_bounce1d | -0.39 % | 3.839e+03 | 3.824e+03 | -14.93 | 68.09 | 68.01 |
test_eq_solve | 0.78 % | 2.049e+03 | 2.065e+03 | 15.96 | 86.84 | 87.12 |For the memory plots, go to the summary of |
Collaborator
Author
|
@f0uriest what do you think about bumping the minimum jax version to 0.6.2? It is almost a year old now (June 17, 2025). |
Collaborator
Author
|
…ding for vmapped operation by looking at the eps range instead of exact range
YigitElma
commented
May 28, 2026
| r = jnp.where( | ||
| (jnp.abs(r.imag) <= eps) & (a_min <= r.real) & (r.real <= a_max), | ||
| r.real, | ||
| (jnp.abs(r.imag) <= eps) |
Collaborator
Author
There was a problem hiding this comment.
I had to add this eps because with newer versions of jax, some stuff that were rounded to 0 now has slight difference which caused the test_z1_first test to fail (first 2 roots were not found).
unalmis
previously requested changes
May 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
- Coverage 94.35% 94.33% -0.02%
==========================================
Files 101 101
Lines 28856 28855 -1
==========================================
- Hits 27226 27221 -5
- Misses 1630 1634 +4
🚀 New features to boost your workflow:
|
ddudt
reviewed
Jun 1, 2026
f0uriest
previously approved these changes
Jun 1, 2026
YigitElma
commented
Jun 1, 2026
| """Coordinate frame of the model.""" | ||
| return self._frame | ||
|
|
||
| @jit |
Collaborator
Author
There was a problem hiding this comment.
I realized this would also have the same problem as #2228
ddudt
approved these changes
Jun 1, 2026
f0uriest
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the dependencies manually before the new release. The Dependabot issue persists.
jax.tree_util.tree_broadcastwas added with jax 0.6.2. Bumped min jax version to 0.6.2 and removed 0.5.0, 0.5.3 and 0.6.1 (they were a year old).New
jaxversions introduce small numerical differences and cause some tests to fail. Sticking withjax<0.10.0for now. Bounce stuff will be fixed in a different PR.