Skip to content

Update dependencies manually#2222

Merged
YigitElma merged 11 commits into
masterfrom
yge/deps
Jun 1, 2026
Merged

Update dependencies manually#2222
YigitElma merged 11 commits into
masterfrom
yge/deps

Conversation

@YigitElma

@YigitElma YigitElma commented May 20, 2026

Copy link
Copy Markdown
Collaborator

Updating the dependencies manually before the new release. The Dependabot issue persists.

jax.tree_util.tree_broadcast was added with jax 0.6.2. Bumped min jax version to 0.6.2 and removed 0.5.0, 0.5.3 and 0.6.1 (they were a year old).

New jax versions introduce small numerical differences and cause some tests to fail. Sticking with jax<0.10.0 for now. Bounce stuff will be fixed in a different PR.

@YigitElma YigitElma added test_jax Run tests against different versions of JAX skip_changelog No need to update changelog on this PR labels May 20, 2026
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Memory benchmark result

|               Test Name                |      %Δ      |    Master (MB)     |      PR (MB)       |    Δ (MB)    |    Time PR (s)     |  Time Master (s)   |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
  test_objective_jac_w7x                 |    3.54 %    |     3.995e+03      |     4.137e+03      |    141.26    |       31.14        |       29.84        |
  test_proximal_jac_w7x_with_eq_update   |   -1.73 %    |     6.610e+03      |     6.496e+03      |   -114.11    |       153.40       |       152.25       |
  test_proximal_freeb_jac                |   -0.25 %    |     1.336e+04      |     1.333e+04      |    -33.24    |       84.14        |       82.15        |
  test_proximal_freeb_jac_blocked        |    0.57 %    |     7.601e+03      |     7.644e+03      |    43.02     |       71.21        |       69.30        |
  test_proximal_freeb_jac_batched        |    0.83 %    |     7.579e+03      |     7.641e+03      |    62.82     |       70.30        |       67.56        |
  test_proximal_jac_ripple               |    3.02 %    |     3.498e+03      |     3.604e+03      |    105.64    |       55.58        |       53.05        |
  test_proximal_jac_ripple_bounce1d      |   -0.39 %    |     3.839e+03      |     3.824e+03      |    -14.93    |       68.09        |       68.01        |
  test_eq_solve                          |    0.78 %    |     2.049e+03      |     2.065e+03      |    15.96     |       86.84        |       87.12        |

For the memory plots, go to the summary of Memory Benchmarks workflow and download the artifact.

@YigitElma

Copy link
Copy Markdown
Collaborator Author

@f0uriest what do you think about bumping the minimum jax version to 0.6.2? It is almost a year old now (June 17, 2025).

@YigitElma

YigitElma commented May 28, 2026

Copy link
Copy Markdown
Collaborator Author
  • Try test_solve_bounds with svd
  • Bump the min version of jax

YigitElma added 2 commits May 29, 2026 00:44
…ding for vmapped operation by looking at the eps range instead of exact range
Comment thread desc/integrals/_interp_utils.py Outdated
r = jnp.where(
(jnp.abs(r.imag) <= eps) & (a_min <= r.real) & (r.real <= a_max),
r.real,
(jnp.abs(r.imag) <= eps)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add this eps because with newer versions of jax, some stuff that were rounded to 0 now has slight difference which caused the test_z1_first test to fail (first 2 roots were not found).

@unalmis unalmis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as the modification to the bounce integrals breaks invariants and leads to errors. If you need to edit bounce integral code your options are to either merge #2226 or merge #2199 which requires the spare pullback pr . Either will take 5 minutes of time.

@codecov

codecov Bot commented May 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.33%. Comparing base (e80e4bb) to head (e550ef3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2222      +/-   ##
==========================================
- Coverage   94.35%   94.33%   -0.02%     
==========================================
  Files         101      101              
  Lines       28856    28855       -1     
==========================================
- Hits        27226    27221       -5     
- Misses       1630     1634       +4     
Files with missing lines Coverage Δ
desc/coils.py 97.96% <100.00%> (ø)
desc/particles.py 92.90% <100.00%> (-0.03%) ⬇️
desc/profiles.py 95.53% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread desc/particles.py
Comment thread desc/particles.py Outdated
Comment thread desc/particles.py Outdated
Comment thread desc/particles.py Outdated
f0uriest
f0uriest previously approved these changes Jun 1, 2026
Comment thread desc/particles.py
"""Coordinate frame of the model."""
return self._frame

@jit

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this would also have the same problem as #2228

@YigitElma YigitElma requested review from ddudt and f0uriest June 1, 2026 18:49
@YigitElma YigitElma merged commit d454fb4 into master Jun 1, 2026
42 checks passed
@YigitElma YigitElma deleted the yge/deps branch June 1, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip_changelog No need to update changelog on this PR test_jax Run tests against different versions of JAX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants