More useful logs#181
Merged
Merged
Conversation
marco-m-pix4d
requested review from
SpectreVert,
aliculPix4D,
iAmoric and
odormond
odormond
approved these changes
Apr 15, 2026
aliculPix4D
reviewed
Apr 15, 2026
aliculPix4D
approved these changes
Apr 15, 2026
iAmoric
approved these changes
Apr 15, 2026
Note: since cogito uses the go-kit/googlechat and go-kit/github wrappers, the change in the go-kit/retry API is invisible from the point of view of cogito. cogito: adapt to changes in go-kit/googlechat cogito: adapt to changes in go-kit/github
We were not printing the timestamp because the Concourse web UI already decorates each build log line with a timestamp. On the other hand, when copying and pasting the build log to report a problem, one has to resort to a screenshot instead of just using the plain text, because the decoration timestamps are not copied to text. Thus this commit adds back the timestamps. In addition, to increase readability, we use a uniform lenght for the log level (eg INF and DBG, instead of INFO and DEBUG). A note regarding the timestamp zone. It will be output in UTC, although the Concourse UI shows the local time. In my understanding, this is due to the fact that cogito, as any Concourse resource, runs in a Docker container.
…g the ghcat space
marco-m-pix4d
force-pushed
the
update-to-gokit
branch
from
cbdcd10 to
30f62db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many quality of life improvements and adapt to (I think) changes to which fields the GoogleChat API actually fills.
User-visible changes in the logs:
Better reviewed commit-per-commit
TODO
-PCI-4096