Skip to content

Fix: stop_crawl() overwrites "completed" status #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liquidpurple wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: stop_crawl() overwrites "completed" status #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/crawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,11 @@ def stop_crawl(self):
# Save final data to database
if self.db_save_enabled and self.crawl_id:
self._save_batch_to_db(force=True)
from src.crawl_db import set_crawl_status
set_crawl_status(self.crawl_id, 'stopped')
from src.crawl_db import get_crawl_by_id, set_crawl_status
crawl = get_crawl_by_id(self.crawl_id)
# Don't overwrite 'completed' status (e.g. from cleanup thread)
if crawl and crawl['status'] != 'completed':
set_crawl_status(self.crawl_id, 'stopped')

# Clean up JavaScript resources if enabled
if self.js_renderer:
Expand Down