Skip to content

added configuration for game duration, server name, map voting and Web interface through env vars - #24

Closed
ppaulis wants to merge 0 commit into
PhasecoreX:masterfrom
osg-lan:master
Closed

ppaulis wants to merge 0 commit into
PhasecoreX:masterfrom
osg-lan:master

Conversation

@ppaulis

@ppaulis ppaulis commented Nov 13, 2024 •

Copy link
Copy Markdown
Contributor

@PhasecoreX
This PR adds environment variables for game duration, server name, map voting and to enable the web interface of the Server.

Map Voting suggests maps from the game modes : Deathmatch, Domination, CTF, Bombing Run, Assault and Onslaught. Variations with Instagib have also been added.

Best regards,
Pascal

@ppaulis

ppaulis commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Hi @PhasecoreX !

Just wanted to know if you had the time to take a look at this? :-)

@PhasecoreX

Copy link
Copy Markdown
Owner

Sorry about that! I have looked at it now.

Server name, web interface, and admin password I think are good. Voting settings are good too, however I think there should be a way to disable it. Currently if they set ENABLE_MAP_VOTING to 0, it won't set it back to False in the config.

I also don't really like the GAME_DURATION one, simply because it modifies all of the game types, and it doesn't modify any custom game types, like JailBreak. I think that's something that would have to be more granular somehow, but I don't want to have a bunch of extra environment variable to support that when it's easier to just manually modify the config file. Best to just remove it.

@ppaulis

ppaulis commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor Author

@PhasecoreX Fixed the map voting and removed the game duration env var 👍 I'll keep the game duration in my own branch then :-)

Comment thread root/app/start_server.sh Outdated
if [ "$ENABLE_WEB_INTERFACE" = "1" ] && [ -n "${ADMIN_PASSWORD:-}" ]; then
sed -i '/\[UWeb.WebServer\]/,/^$/s/bEnabled=False/bEnabled=True/' /data/config/UT2004.ini
sed -i "/\[Engine.AccessControl\]/,/^$/s/^AdminPassword=.*/AdminPassword=${ADMIN_PASSWORD}/" /data/config/UT2004.ini
fi

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add elif [ "$ENABLE_WEB_INTERFACE" = "0" ]; then so that we can disable the web interface as well. Don't need to check the admin password when disabling.

@PhasecoreX

Copy link
Copy Markdown
Owner

Sorry, forgot about disabling the web interface. Just add that and then we should be good!

@PhasecoreX

PhasecoreX commented Aug 31, 2026 •

Copy link
Copy Markdown
Owner

I'm also thinking that instead of "1" and "0", we use "true" and "false". We are already using "true" in this image for the SKIP_INSTALL environment variable, as well as ut99-server.

@ppaulis

ppaulis commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@PhasecoreX Replaced by #33
Sorry, messed up the original PR ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants