fix(cli): skip DSTACK_AUTHORIZED_KEYS injection when --no-dev-os is set#466
Open
Leechael wants to merge 2 commits into
Open
fix(cli): skip DSTACK_AUTHORIZED_KEYS injection when --no-dev-os is set#466Leechael wants to merge 2 commits into
Leechael wants to merge 2 commits into
Conversation
Previously, `--no-dev-os --ssh-pubkey <path>` still injected the SSH public key into DSTACK_AUTHORIZED_KEYS. Non-dev images do not run an SSH daemon, so injecting the key is pointless and leaks the pubkey into the encrypted environment. Now `--no-dev-os` unconditionally skips SSH key injection regardless of whether `--ssh-pubkey` is provided.
Collaborator
Author
|
!release cli patch beta |
Contributor
|
🚀 @Leechael release command accepted: 📦 Prerelease tag: |
Contributor
|
🎉 Release completed:
📦 Package Info
📄 Files included |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-dev-osis set,readSshPubkeynow returnsundefinedunconditionally, soDSTACK_AUTHORIZED_KEYSis never injected into the encrypted environment.--no-dev-os --ssh-pubkey <path>still injected the SSH public key. Non-dev images don't run an SSH daemon, so injecting the key was pointless and leaked the pubkey into the encrypted env.Test plan
bun test src/commands/deploy/handler.test.ts— 38 pass