Skip to content

remove unused sibling fields #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PeteRager merged 2 commits into from
Mar 26, 2026
Merged

remove unused sibling fields #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1642d2
remove unused sibling fields
PeteRager Dec 25, 2025
12f1f5c
add info alert
PeteRager Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions lennoxs30api/s30api_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@
LENNOX_ALERT_CRITICAL = "critical"
LENNOX_ALERT_MODERATE = "moderate"
LENNOX_ALERT_MINOR = "minor"
LENNOX_ALERT_INFO = "info"
LENNOX_ALERT_NONE = "none"

# Percentage
Expand Down Expand Up @@ -1104,14 +1105,7 @@ def __init__(self, sysId: str):
self.sa_setpointState: str = None
# Sibling data
self.siblings: list[SiblingInfo] = []
# TODO remove these fields, use siblings list
self.sibling_self_identifier: str = None
self.sibling_identifier: str = None
self.sibling_systemName: str = None
self.sibling_nodePresent: str = None
self.sibling_portNumber: str = None
self.sibling_ipAddress: str = None


# iHarmony Zoning Mode
self.centralMode: bool = None
self.zoningMode: str = None
Expand Down