Repository navigation
Consistency batches A/B: 101 conclusion-first renames, OEIS placement, preserves checker - #2575
Open
PerAlexandersson wants to merge 1 commit into
Open
PerAlexandersson wants to merge 1 commit into
PerAlexandersson wants to merge 1 commit into
Conversation
…ianTriangles/LagTwoOperators.lean; do not merge) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements batches A and B of a source-level API and naming consistency audit of recently added
declarations (101 actions), plus a checker fix. Statements and proofs are unchanged except where two
duplicate implementations become one theorem.
(AGENTS "Names, Hypotheses and Deprecation"), 11 lowercase OEIS-tag names moved into
Applications/OEIS, 3 duplicate consolidations, 2 theorem backends moved out ofTactic/.New modules:
Applications/OEIS/A114123.lean,DerivativeRecurrence/HalfDegree.lean.Removed one unused degree-two even-binomial specialization.
@[deprecated (since := "2026-11-14")] aliasfor the old names.check_declaration_names.pyno longer flags UpperCamelCasePreserves…predicatedefinitions or conclusion-named counting theorems (
preservesbaseline 21 → 0; self-tests added).name = …entry andtactic_routes.jsonentry is migrated.Not in this PR: batch C (19 predicate restatements, which change statements) and the family-rule
ownership policy; tracked in Consistency batch C: predicate restatements, and the catalog family-name rule #2574.
Verification (exact head 4602eba)
lake build RealRooted.Production RealRooted.Tactic.Examples: 11301 jobs, no errors.lake exe runLinteron each of the 58 changed or new library modules: passed.import architecture, catalog
--checkand audit, catalog unit tests, OEIS coverage regeneration:passed.
lint-styleis left to CI.Rename table (101)
RealRooted.basisTransform_orderTwoBasis_preserves_bounded_pf_iffRealRooted.OrderTwoBasis.forall_isPFPolynomial_iff_of_root_boundsRealRooted.evenDerivative_preservesPF_tfaeRealRooted.EvenDerivative.isPFPolynomial_tfaeRealRooted.leanderTransform_preserves_compatibilityRealRooted.Compatible.leanderTransform_orderedRealRooted.raySemigroupTransform_preservesPF_iffRealRooted.RaySemigroup.forall_isPFPolynomial_iffRealRooted.raySemigroupTransform_preservesPF_iff_finiteLogRealRooted.RaySemigroup.forall_isPFPolynomial_iff_finiteLogRealRooted.finiteFreeAdditiveConvolutionDegreeBox_preservesRealStabilityRealRooted.BorceaBranden.PreservesRealStabilityOnDegreeBox.finiteFreeAdditiveConvolutionRealRooted.FiniteDegreeOrdered.differentialTests_ordered_of_preservesOrderedPFUpToRealRooted.PreservesOrderedPFUpTo.differentialTestsRealRooted.finiteDifferentialTest_ordered_of_preservesOrderedPFUpToRealRooted.PreservesOrderedPFUpTo.differentialTestsRealRooted.LinearMap.map_weightedSumRealRooted.map_weightedSumRealRooted.ParityHypRealRooted.IsParityKernelRealRooted.a157147To151RowRealRooted.unitLagTwoEulerRowRealRooted.a157147To151Row_simpleNegRooted_and_strictInterlRealRooted.unitLagTwoEulerRow_simpleNegRooted_and_strictInterlRealRooted.a157637RowRealRooted.halfIndexLagTwoEulerRowRealRooted.a157637Row_simpleNegRooted_and_strictInterlRealRooted.halfIndexLagTwoEulerRow_simpleNegRooted_and_strictInterlRealRooted.a371898RowRealRooted.unitNegativeLagEulerRowRealRooted.a371898Row_degree_pos_rootedRealRooted.unitNegativeLagEulerRow_degree_pos_rootedRealRooted.Tactic.derivativeRecurrence_strictInterl_of_half_degreeRealRooted.derivativeRecurrence_strictInterl_of_half_degreeRealRooted.Tactic.derivativeRecurrence_strictInterl_of_floor_half_degreeRealRooted.derivativeRecurrence_strictInterl_of_floor_half_degreeRealRooted.PFRiordan.a114123KCoeffRealRooted.Applications.OEIS.A114123.kCoeffRealRooted.PFRiordan.mk_a114123KCoeff_mul_one_subRealRooted.Applications.OEIS.A114123.mk_kCoeff_mul_one_subRealRooted.PFRiordan.a114123RowRealRooted.Applications.OEIS.A114123.rowRealRooted.PFRiordan.a114123_denominator_mul_rowGeneratingSeriesRealRooted.Applications.OEIS.A114123.denominator_mul_rowGeneratingSeriesRealRooted.PFRiordan.a114123Row_splits_and_roots_nonposRealRooted.Applications.OEIS.A114123.row_splits_and_roots_nonposRealRooted.basisTransform_orderTwoBasis_preserves_pf_iff_rows_pfRealRooted.OrderTwoBasis.forall_isPFPolynomial_iff_rowsRealRooted.NewtonParametersAffine.preservesNonposRootedRealRooted.NewtonPreservesNonposRooted.of_parametersAffineRealRooted.NewtonParametersAffineUpTo.preservesNonposRootedUpToRealRooted.NewtonPreservesNonposRootedUpTo.of_parametersAffineUpToRealRooted.SimpleNegRooted.lagTwoEulerCore_preservesRealRooted.SimpleNegRooted.lagTwoEulerCoreRealRooted.HasKreinCompanionExpansion.preservesOrderedPFRealRooted.HasKreinCompanionExpansion.isPFPolynomial_and_interlRealRooted.preservesOrderedPFUpTo_multishift_removeNthRealRooted.PreservesOrderedPFUpTo.multishiftDifferentialSymbol_removeNthRealRooted.FiniteDegreeOrdered.preservesOrderedPFUpTo_of_differentialTestsRealRooted.PreservesOrderedPFUpTo.of_differentialTestsRealRooted.FiniteDegreeOrdered.preservesOrderedPFUpTo_capNormalizedDifferentialSymbolRealRooted.PreservesOrderedPFUpTo.capNormalizedDifferentialSymbolRealRooted.preservesOrderedPFUpTo_iff_hasFiniteCapCompanionConeRealRooted.PreservesOrderedPFUpTo.iff_hasFiniteCapCompanionConeRealRooted.nonneg_of_preservesScaledPFTripleRealRooted.PreservesScaledPFTriple.nonnegRealRooted.besselAuxiliaryRealRooted.besselHomogenizationRealRooted.eval_besselAuxiliaryRealRooted.eval_besselHomogenizationRealRooted.eval_besselAuxiliary_eq_pow_mulRealRooted.eval_besselHomogenization_eq_pow_mulRealRooted.mvUpperHalfPlaneStable_besselAuxiliaryRealRooted.mvUpperHalfPlaneStable_besselHomogenizationRealRooted.besselAuxiliary_coeff_zero_orRealRooted.mvUpperHalfPlaneStableOrZero_coeff_besselHomogenizationRealRooted.besselAuxiliary_coeffRealRooted.coeff_besselHomogenizationRealRooted.laguerreAuxiliary_monicRealRooted.monic_laguerrePochhammerSumRealRooted.ParityHyp.blockTP2RealRooted.IsParityKernel.isTP2_parityBlockRealRooted.ParityHyp.blockColRealRooted.IsParityKernel.parityBlock_apply_le_of_leRealRooted.ParityHyp.blockRowRealRooted.IsParityKernel.parityBlock_apply_eq_of_leRealRooted.ParityHyp.monic_natDegree_uRealRooted.IsParityKernel.monic_natDegree_uRealRooted.ParityHyp.monic_natDegree_vRealRooted.IsParityKernel.monic_natDegree_vRealRooted.ParityHyp.isRealRootedIn_uRealRooted.IsParityKernel.isRealRootedIn_uRealRooted.ParityHyp.isRealRootedIn_vRealRooted.IsParityKernel.isRealRootedIn_vRealRooted.ParityHyp.eval_zero_u_mul_vRealRooted.IsParityKernel.eval_zero_u_mul_vRealRooted.ParityHyp.eval_zero_u_neRealRooted.IsParityKernel.eval_zero_u_neRealRooted.ParityHyp.eval_zero_v_neRealRooted.IsParityKernel.eval_zero_v_neRealRooted.ParityHyp.pos_of_isRoot_uRealRooted.IsParityKernel.pos_of_isRoot_uRealRooted.ParityHyp.pos_of_isRoot_vRealRooted.IsParityKernel.pos_of_isRoot_vRealRooted.ParityHyp.strictInterl_v_uRealRooted.IsParityKernel.strictInterl_v_uRealRooted.ParityHyp.strictInterl_u_vRealRooted.IsParityKernel.strictInterl_u_vRealRooted.ParityHyp.no_common_root_v_uRealRooted.IsParityKernel.no_common_root_v_uRealRooted.ParityHyp.no_common_root_u_vRealRooted.IsParityKernel.no_common_root_u_vRealRooted.ParityHyp.eval_v_mul_derivative_u_posRealRooted.IsParityKernel.eval_v_mul_derivative_u_posRealRooted.ParityHyp.eval_u_mul_derivative_v_posRealRooted.IsParityKernel.eval_u_mul_derivative_v_posRealRooted.ParityHyp.parityRow_evenRealRooted.IsParityKernel.parityRow_evenRealRooted.ParityHyp.parityRow_oddRealRooted.IsParityKernel.parityRow_oddRealRooted.ParityHyp.interlaces_isCoprime_evenRealRooted.IsParityKernel.interlaces_isCoprime_evenRealRooted.ParityHyp.interlaces_isCoprime_oddRealRooted.IsParityKernel.interlaces_isCoprime_oddRealRooted.ParityHyp.interlaces_isCoprimeRealRooted.IsParityKernel.interlaces_isCoprimeRealRooted.ParityHyp.parityRow_monic_natDegree_splitsRealRooted.IsParityKernel.parityRow_monic_natDegree_splitsRealRooted.ParityHyp.parityRow_certificate_zeroRealRooted.IsParityKernel.parityRow_certificate_zeroRealRooted.ParityHyp.parityRow_certificateRealRooted.IsParityKernel.parityRow_certificateRealRooted.two_mul_coeff_one_appellCoefficient_two_nonneg_of_shiftedPower_splitsRealRooted.AppellCoefficient.two_mul_coeff_one_nonneg_of_shiftedPower_splitsRealRooted.basisTransform_eq_sum_iterate_derivative_of_isAppellExpansionRealRooted.IsAppellExpansion.basisTransform_eq_sum_iterate_derivativeRealRooted.forall_appellCoefficient_natDegree_eq_zero_iff_commutes_translationRealRooted.AppellCoefficient.forall_natDegree_eq_zero_iff_commutes_translationRealRooted.limitingAppellCoefficient_two_eq_half_square_of_eq_pow_div_factorialRealRooted.LimitingAppell.coeff_two_eq_half_square_of_eq_pow_div_factorialRealRooted.forall_limitingAppellPolynomial_eq_iff_coeff_eq_pow_div_factorialRealRooted.LimitingAppell.forall_polynomial_eq_iff_coeff_eq_pow_div_factorialRealRooted.rationalSubstitution_chebyshev_T_add_C_eq_evenBinomPolyReal_addRealRooted.Chebyshev.rationalSubstitution_T_add_C_eqRealRooted.finiteFreeAdditiveConvolutionGamma_eq_factorial_mul_descFactorialRealRooted.FiniteFreeAdditive.convolutionGamma_eq_factorial_mul_descFactorialRealRooted.not_splits_secondOrderRayOperator_X_pow_of_explicit_discrim_negRealRooted.SecondOrderRay.not_splits_X_pow_of_discrim_negRealRooted.isRoot_eq_neg_one_or_mem_Ioo_of_reflectedJacobiOperator_eq_zeroRealRooted.ReflectedJacobi.eq_neg_one_or_mem_Ioo_of_isRootRealRooted.eulerShiftRange_diagonal_eq_C_mul_jacobiCoefficientPolynomialRealRooted.JacobiCoefficientPolynomial.eulerShiftRange_diagonal_eq_C_mulRealRooted.eval_eq_risingFactorial_div_of_diagonalOperator_jacobiCoefficientPolynomialRealRooted.JacobiCoefficientPolynomial.eval_eq_risingFactorial_divRealRooted.exists_rowScalar_diagonalOperator_jacobiCoefficientPolynomial_iffRealRooted.JacobiCoefficientPolynomial.exists_rowScalar_diagonalOperator_iffRealRooted.diagonalOperator_jacobiCoefficientPolynomial_iff_eq_multiplierPolynomialRealRooted.JacobiCoefficientPolynomial.diagonalOperator_iff_eq_multiplierPolynomialRealRooted.exists_natDegree_lt_add_and_mul_generatingSeries_eq_of_pureLag_fromRealRooted.EndpointRecurrence.exists_natDegree_lt_and_mul_generatingSeries_eq_of_pureLagRealRooted.isRealRootedIn_Icc_brandenE_X_sub_C_mul_X_sub_C_of_lt_neg_oneRealRooted.BrandenE.isRealRootedIn_Icc_quadratic_of_lt_neg_oneRealRooted.isRealRootedIn_Icc_brandenE_X_sub_C_mul_X_sub_C_of_lt_neg_one_of_posRealRooted.BrandenE.isRealRootedIn_Icc_quadratic_of_lt_neg_one_of_posRealRooted.veroneseSectionPolynomial_X_add_half_pow_comp_eq_of_fibonacci_recurrenceRealRooted.VeroneseRecognition.section_X_add_half_pow_comp_eq_of_fibonacci_recurrenceRealRooted.Hoggatt.polynomial_pred_interlacesRealRooted.Hoggatt.polynomial_pred_interlaces_and_isCoprimeRealRooted.Hoggatt.baxter_interlacesRealRooted.Hoggatt.baxter_interlaces_and_isCoprimeRealRooted.IsPFPolynomial.degreeControlledDerivativeImage_isPF_and_strictInterlRealRooted.IsPFPolynomial.degreeControlledDerivativeImage_and_strictInterlRealRooted.BrandenLeite.affineLogCoeff_pf_and_interl_of_positive_powersRealRooted.BrandenLeite.affineLogCoeff_isPFPolynomial_and_interl_of_posRealRooted.BrandenLeite.affineLogCoeff_factor_pf_and_interlRealRooted.BrandenLeite.affineLogCoeff_factor_isPFPolynomial_and_interlRealRooted.BrandenLeite.exists_pf_coeff_one_pos_approximationRealRooted.BrandenLeite.exists_isPFPolynomial_coeff_one_pos_approximationRealRooted.affineDifferentialRow_pf_and_interlRealRooted.affineDifferentialRow_isPFPolynomial_and_interlRealRooted.emptyMultishiftRecurrence_pf_and_interlRealRooted.emptyMultishiftRecurrence_isPFPolynomial_and_interlRealRooted.multishiftDifferentialRecurrence_pf_and_interlRealRooted.IsPFPolynomial.multishiftDifferentialRecurrence_and_interlRealRooted.FiniteDegreeOrdered.binomialDifferentialRecurrence_pf_and_interlRealRooted.IsPFPolynomial.binomialDifferentialRecurrence_and_interlRealRooted.differentialRecurrence_pf_and_interlRealRooted.differentialRecurrence_isPFPolynomial_and_interlRealRooted.affineDRow_pf_through_iffRealRooted.affineDRow_isPFPolynomial_upTo_iffRealRooted.affineDRow_pf_iffRealRooted.affineDRow_isPFPolynomial_iffRealRooted.Hypergeometric.threeFTwoCoeff_eq_zeroRealRooted.Hypergeometric.threeFTwoCoeff_eq_zero_of_ltRealRooted.Hypergeometric.monicThreeFTwo_eqRealRooted.Hypergeometric.monicThreeFTwo_eq_C_mulRealRooted.preservesScaledPFTriple_of_nonnegRealRooted.PreservesScaledPFTriple.of_nonnegRealRooted.pathDerivativeImage_isPF_and_strictInterlRealRooted.pathDerivativeImage_isPFPolynomial_and_strictInterlRealRooted.growingZeroFamily_pf_degree_multiplicity_interlacingRealRooted.GrowingZeroFamily.isPFPolynomial_degree_multiplicity_interlacing🤖 Generated with Claude Code