Skip to content

Consistency batches A/B: 101 conclusion-first renames, OEIS placement, preserves checker - #2575

Open
PerAlexandersson wants to merge 1 commit into
mainfrom
cleanup/consistency-batch-a
Open

PerAlexandersson wants to merge 1 commit into
mainfrom
cleanup/consistency-batch-a

Conversation

@PerAlexandersson

Copy link
Copy Markdown
Owner

Implements batches A and B of a source-level API and naming consistency audit of recently added
declarations (101 actions), plus a checker fix. Statements and proofs are unchanged except where two
duplicate implementations become one theorem.

  • Batch A (98, no downstream use): 85 conclusion-first renames into predicate namespaces
    (AGENTS "Names, Hypotheses and Deprecation"), 11 lowercase OEIS-tag names moved into
    Applications/OEIS, 3 duplicate consolidations, 2 theorem backends moved out of Tactic/.
    New modules: Applications/OEIS/A114123.lean, DerivativeRecurrence/HalfDegree.lean.
    Removed one unused degree-two even-binomial specialization.
  • Batch B (3, used downstream): signature-preserving renames with
    @[deprecated (since := "2026-11-14")] alias for the old names.
  • Checker: check_declaration_names.py no longer flags UpperCamelCase Preserves… predicate
    definitions or conclusion-named counting theorems (preserves baseline 21 → 0; self-tests added).
  • Every in-repository caller, catalog name = … entry and tactic_routes.json entry is migrated.
    Not in this PR: batch C (19 predicate restatements, which change statements) and the family-rule
    ownership policy; tracked in Consistency batch C: predicate restatements, and the catalog family-name rule #2574.

Verification (exact head 4602eba)

  • Local lake build RealRooted.Production RealRooted.Tactic.Examples: 11301 jobs, no errors.
  • lake exe runLinter on each of the 58 changed or new library modules: passed.
  • Source guards: declaration names (+ self-test), proof status, root imports, module system,
    import architecture, catalog --check and audit, catalog unit tests, OEIS coverage regeneration:
    passed. lint-style is left to CI.
  • 101 signature comparisons old vs new (binders and statements identical for pure renames).
Rename table (101)
Old New Batch
RealRooted.basisTransform_orderTwoBasis_preserves_bounded_pf_iff RealRooted.OrderTwoBasis.forall_isPFPolynomial_iff_of_root_bounds A
RealRooted.evenDerivative_preservesPF_tfae RealRooted.EvenDerivative.isPFPolynomial_tfae A
RealRooted.leanderTransform_preserves_compatibility RealRooted.Compatible.leanderTransform_ordered A
RealRooted.raySemigroupTransform_preservesPF_iff RealRooted.RaySemigroup.forall_isPFPolynomial_iff A
RealRooted.raySemigroupTransform_preservesPF_iff_finiteLog RealRooted.RaySemigroup.forall_isPFPolynomial_iff_finiteLog A
RealRooted.finiteFreeAdditiveConvolutionDegreeBox_preservesRealStability RealRooted.BorceaBranden.PreservesRealStabilityOnDegreeBox.finiteFreeAdditiveConvolution A
RealRooted.FiniteDegreeOrdered.differentialTests_ordered_of_preservesOrderedPFUpTo RealRooted.PreservesOrderedPFUpTo.differentialTests A
RealRooted.finiteDifferentialTest_ordered_of_preservesOrderedPFUpTo RealRooted.PreservesOrderedPFUpTo.differentialTests A
RealRooted.LinearMap.map_weightedSum RealRooted.map_weightedSum A
RealRooted.ParityHyp RealRooted.IsParityKernel A
RealRooted.a157147To151Row RealRooted.unitLagTwoEulerRow A
RealRooted.a157147To151Row_simpleNegRooted_and_strictInterl RealRooted.unitLagTwoEulerRow_simpleNegRooted_and_strictInterl A
RealRooted.a157637Row RealRooted.halfIndexLagTwoEulerRow A
RealRooted.a157637Row_simpleNegRooted_and_strictInterl RealRooted.halfIndexLagTwoEulerRow_simpleNegRooted_and_strictInterl A
RealRooted.a371898Row RealRooted.unitNegativeLagEulerRow A
RealRooted.a371898Row_degree_pos_rooted RealRooted.unitNegativeLagEulerRow_degree_pos_rooted A
RealRooted.Tactic.derivativeRecurrence_strictInterl_of_half_degree RealRooted.derivativeRecurrence_strictInterl_of_half_degree A
RealRooted.Tactic.derivativeRecurrence_strictInterl_of_floor_half_degree RealRooted.derivativeRecurrence_strictInterl_of_floor_half_degree A
RealRooted.PFRiordan.a114123KCoeff RealRooted.Applications.OEIS.A114123.kCoeff A
RealRooted.PFRiordan.mk_a114123KCoeff_mul_one_sub RealRooted.Applications.OEIS.A114123.mk_kCoeff_mul_one_sub A
RealRooted.PFRiordan.a114123Row RealRooted.Applications.OEIS.A114123.row A
RealRooted.PFRiordan.a114123_denominator_mul_rowGeneratingSeries RealRooted.Applications.OEIS.A114123.denominator_mul_rowGeneratingSeries A
RealRooted.PFRiordan.a114123Row_splits_and_roots_nonpos RealRooted.Applications.OEIS.A114123.row_splits_and_roots_nonpos A
RealRooted.basisTransform_orderTwoBasis_preserves_pf_iff_rows_pf RealRooted.OrderTwoBasis.forall_isPFPolynomial_iff_rows A
RealRooted.NewtonParametersAffine.preservesNonposRooted RealRooted.NewtonPreservesNonposRooted.of_parametersAffine A
RealRooted.NewtonParametersAffineUpTo.preservesNonposRootedUpTo RealRooted.NewtonPreservesNonposRootedUpTo.of_parametersAffineUpTo A
RealRooted.SimpleNegRooted.lagTwoEulerCore_preserves RealRooted.SimpleNegRooted.lagTwoEulerCore A
RealRooted.HasKreinCompanionExpansion.preservesOrderedPF RealRooted.HasKreinCompanionExpansion.isPFPolynomial_and_interl A
RealRooted.preservesOrderedPFUpTo_multishift_removeNth RealRooted.PreservesOrderedPFUpTo.multishiftDifferentialSymbol_removeNth A
RealRooted.FiniteDegreeOrdered.preservesOrderedPFUpTo_of_differentialTests RealRooted.PreservesOrderedPFUpTo.of_differentialTests A
RealRooted.FiniteDegreeOrdered.preservesOrderedPFUpTo_capNormalizedDifferentialSymbol RealRooted.PreservesOrderedPFUpTo.capNormalizedDifferentialSymbol A
RealRooted.preservesOrderedPFUpTo_iff_hasFiniteCapCompanionCone RealRooted.PreservesOrderedPFUpTo.iff_hasFiniteCapCompanionCone A
RealRooted.nonneg_of_preservesScaledPFTriple RealRooted.PreservesScaledPFTriple.nonneg A
RealRooted.besselAuxiliary RealRooted.besselHomogenization A
RealRooted.eval_besselAuxiliary RealRooted.eval_besselHomogenization A
RealRooted.eval_besselAuxiliary_eq_pow_mul RealRooted.eval_besselHomogenization_eq_pow_mul A
RealRooted.mvUpperHalfPlaneStable_besselAuxiliary RealRooted.mvUpperHalfPlaneStable_besselHomogenization A
RealRooted.besselAuxiliary_coeff_zero_or RealRooted.mvUpperHalfPlaneStableOrZero_coeff_besselHomogenization A
RealRooted.besselAuxiliary_coeff RealRooted.coeff_besselHomogenization A
RealRooted.laguerreAuxiliary_monic RealRooted.monic_laguerrePochhammerSum A
RealRooted.ParityHyp.blockTP2 RealRooted.IsParityKernel.isTP2_parityBlock A
RealRooted.ParityHyp.blockCol RealRooted.IsParityKernel.parityBlock_apply_le_of_le A
RealRooted.ParityHyp.blockRow RealRooted.IsParityKernel.parityBlock_apply_eq_of_le A
RealRooted.ParityHyp.monic_natDegree_u RealRooted.IsParityKernel.monic_natDegree_u A
RealRooted.ParityHyp.monic_natDegree_v RealRooted.IsParityKernel.monic_natDegree_v A
RealRooted.ParityHyp.isRealRootedIn_u RealRooted.IsParityKernel.isRealRootedIn_u A
RealRooted.ParityHyp.isRealRootedIn_v RealRooted.IsParityKernel.isRealRootedIn_v A
RealRooted.ParityHyp.eval_zero_u_mul_v RealRooted.IsParityKernel.eval_zero_u_mul_v A
RealRooted.ParityHyp.eval_zero_u_ne RealRooted.IsParityKernel.eval_zero_u_ne A
RealRooted.ParityHyp.eval_zero_v_ne RealRooted.IsParityKernel.eval_zero_v_ne A
RealRooted.ParityHyp.pos_of_isRoot_u RealRooted.IsParityKernel.pos_of_isRoot_u A
RealRooted.ParityHyp.pos_of_isRoot_v RealRooted.IsParityKernel.pos_of_isRoot_v A
RealRooted.ParityHyp.strictInterl_v_u RealRooted.IsParityKernel.strictInterl_v_u A
RealRooted.ParityHyp.strictInterl_u_v RealRooted.IsParityKernel.strictInterl_u_v A
RealRooted.ParityHyp.no_common_root_v_u RealRooted.IsParityKernel.no_common_root_v_u A
RealRooted.ParityHyp.no_common_root_u_v RealRooted.IsParityKernel.no_common_root_u_v A
RealRooted.ParityHyp.eval_v_mul_derivative_u_pos RealRooted.IsParityKernel.eval_v_mul_derivative_u_pos A
RealRooted.ParityHyp.eval_u_mul_derivative_v_pos RealRooted.IsParityKernel.eval_u_mul_derivative_v_pos A
RealRooted.ParityHyp.parityRow_even RealRooted.IsParityKernel.parityRow_even A
RealRooted.ParityHyp.parityRow_odd RealRooted.IsParityKernel.parityRow_odd A
RealRooted.ParityHyp.interlaces_isCoprime_even RealRooted.IsParityKernel.interlaces_isCoprime_even A
RealRooted.ParityHyp.interlaces_isCoprime_odd RealRooted.IsParityKernel.interlaces_isCoprime_odd A
RealRooted.ParityHyp.interlaces_isCoprime RealRooted.IsParityKernel.interlaces_isCoprime A
RealRooted.ParityHyp.parityRow_monic_natDegree_splits RealRooted.IsParityKernel.parityRow_monic_natDegree_splits A
RealRooted.ParityHyp.parityRow_certificate_zero RealRooted.IsParityKernel.parityRow_certificate_zero A
RealRooted.ParityHyp.parityRow_certificate RealRooted.IsParityKernel.parityRow_certificate A
RealRooted.two_mul_coeff_one_appellCoefficient_two_nonneg_of_shiftedPower_splits RealRooted.AppellCoefficient.two_mul_coeff_one_nonneg_of_shiftedPower_splits A
RealRooted.basisTransform_eq_sum_iterate_derivative_of_isAppellExpansion RealRooted.IsAppellExpansion.basisTransform_eq_sum_iterate_derivative A
RealRooted.forall_appellCoefficient_natDegree_eq_zero_iff_commutes_translation RealRooted.AppellCoefficient.forall_natDegree_eq_zero_iff_commutes_translation A
RealRooted.limitingAppellCoefficient_two_eq_half_square_of_eq_pow_div_factorial RealRooted.LimitingAppell.coeff_two_eq_half_square_of_eq_pow_div_factorial A
RealRooted.forall_limitingAppellPolynomial_eq_iff_coeff_eq_pow_div_factorial RealRooted.LimitingAppell.forall_polynomial_eq_iff_coeff_eq_pow_div_factorial A
RealRooted.rationalSubstitution_chebyshev_T_add_C_eq_evenBinomPolyReal_add RealRooted.Chebyshev.rationalSubstitution_T_add_C_eq A
RealRooted.finiteFreeAdditiveConvolutionGamma_eq_factorial_mul_descFactorial RealRooted.FiniteFreeAdditive.convolutionGamma_eq_factorial_mul_descFactorial A
RealRooted.not_splits_secondOrderRayOperator_X_pow_of_explicit_discrim_neg RealRooted.SecondOrderRay.not_splits_X_pow_of_discrim_neg A
RealRooted.isRoot_eq_neg_one_or_mem_Ioo_of_reflectedJacobiOperator_eq_zero RealRooted.ReflectedJacobi.eq_neg_one_or_mem_Ioo_of_isRoot A
RealRooted.eulerShiftRange_diagonal_eq_C_mul_jacobiCoefficientPolynomial RealRooted.JacobiCoefficientPolynomial.eulerShiftRange_diagonal_eq_C_mul A
RealRooted.eval_eq_risingFactorial_div_of_diagonalOperator_jacobiCoefficientPolynomial RealRooted.JacobiCoefficientPolynomial.eval_eq_risingFactorial_div A
RealRooted.exists_rowScalar_diagonalOperator_jacobiCoefficientPolynomial_iff RealRooted.JacobiCoefficientPolynomial.exists_rowScalar_diagonalOperator_iff A
RealRooted.diagonalOperator_jacobiCoefficientPolynomial_iff_eq_multiplierPolynomial RealRooted.JacobiCoefficientPolynomial.diagonalOperator_iff_eq_multiplierPolynomial A
RealRooted.exists_natDegree_lt_add_and_mul_generatingSeries_eq_of_pureLag_from RealRooted.EndpointRecurrence.exists_natDegree_lt_and_mul_generatingSeries_eq_of_pureLag A
RealRooted.isRealRootedIn_Icc_brandenE_X_sub_C_mul_X_sub_C_of_lt_neg_one RealRooted.BrandenE.isRealRootedIn_Icc_quadratic_of_lt_neg_one A
RealRooted.isRealRootedIn_Icc_brandenE_X_sub_C_mul_X_sub_C_of_lt_neg_one_of_pos RealRooted.BrandenE.isRealRootedIn_Icc_quadratic_of_lt_neg_one_of_pos A
RealRooted.veroneseSectionPolynomial_X_add_half_pow_comp_eq_of_fibonacci_recurrence RealRooted.VeroneseRecognition.section_X_add_half_pow_comp_eq_of_fibonacci_recurrence A
RealRooted.Hoggatt.polynomial_pred_interlaces RealRooted.Hoggatt.polynomial_pred_interlaces_and_isCoprime A
RealRooted.Hoggatt.baxter_interlaces RealRooted.Hoggatt.baxter_interlaces_and_isCoprime A
RealRooted.IsPFPolynomial.degreeControlledDerivativeImage_isPF_and_strictInterl RealRooted.IsPFPolynomial.degreeControlledDerivativeImage_and_strictInterl A
RealRooted.BrandenLeite.affineLogCoeff_pf_and_interl_of_positive_powers RealRooted.BrandenLeite.affineLogCoeff_isPFPolynomial_and_interl_of_pos A
RealRooted.BrandenLeite.affineLogCoeff_factor_pf_and_interl RealRooted.BrandenLeite.affineLogCoeff_factor_isPFPolynomial_and_interl A
RealRooted.BrandenLeite.exists_pf_coeff_one_pos_approximation RealRooted.BrandenLeite.exists_isPFPolynomial_coeff_one_pos_approximation A
RealRooted.affineDifferentialRow_pf_and_interl RealRooted.affineDifferentialRow_isPFPolynomial_and_interl A
RealRooted.emptyMultishiftRecurrence_pf_and_interl RealRooted.emptyMultishiftRecurrence_isPFPolynomial_and_interl A
RealRooted.multishiftDifferentialRecurrence_pf_and_interl RealRooted.IsPFPolynomial.multishiftDifferentialRecurrence_and_interl A
RealRooted.FiniteDegreeOrdered.binomialDifferentialRecurrence_pf_and_interl RealRooted.IsPFPolynomial.binomialDifferentialRecurrence_and_interl A
RealRooted.differentialRecurrence_pf_and_interl RealRooted.differentialRecurrence_isPFPolynomial_and_interl A
RealRooted.affineDRow_pf_through_iff RealRooted.affineDRow_isPFPolynomial_upTo_iff A
RealRooted.affineDRow_pf_iff RealRooted.affineDRow_isPFPolynomial_iff A
RealRooted.Hypergeometric.threeFTwoCoeff_eq_zero RealRooted.Hypergeometric.threeFTwoCoeff_eq_zero_of_lt A
RealRooted.Hypergeometric.monicThreeFTwo_eq RealRooted.Hypergeometric.monicThreeFTwo_eq_C_mul A
RealRooted.preservesScaledPFTriple_of_nonneg RealRooted.PreservesScaledPFTriple.of_nonneg B
RealRooted.pathDerivativeImage_isPF_and_strictInterl RealRooted.pathDerivativeImage_isPFPolynomial_and_strictInterl B
RealRooted.growingZeroFamily_pf_degree_multiplicity_interlacing RealRooted.GrowingZeroFamily.isPFPolynomial_degree_multiplicity_interlacing B

🤖 Generated with Claude Code

…ianTriangles/LagTwoOperators.lean; do not merge)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant