Skip to content

Simplify commands to automatically detect modality#49

Merged
mattcieslak merged 17 commits into
mainfrom
simplify-commands
Apr 24, 2026
Merged

Simplify commands to automatically detect modality#49
mattcieslak merged 17 commits into
mainfrom
simplify-commands

Conversation

@tsalo

@tsalo tsalo commented Apr 1, 2026

Copy link
Copy Markdown
Member

Closes #41.

@codecov-commenter

codecov-commenter commented Apr 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.93252% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.35%. Comparing base (dd8cd8a) to head (9042f17).

Files with missing lines Patch % Lines
src/modelarrayio/cli/h5_to_mif.py 25.00% 3 Missing ⚠️
src/modelarrayio/cli/export_results.py 97.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   69.10%   70.35%   +1.24%     
==========================================
  Files          17       19       +2     
  Lines        1162     1167       +5     
  Branches      211      228      +17     
==========================================
+ Hits          803      821      +18     
+ Misses        295      284      -11     
+ Partials       64       62       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo tsalo requested a review from mattcieslak April 13, 2026 19:11
@tsalo tsalo requested review from araikes and tien-tong April 22, 2026 15:56
Comment thread src/modelarrayio/cli/to_modelarray.py Outdated
Comment thread src/modelarrayio/cli/export_results.py
Comment thread src/modelarrayio/cli/to_modelarray.py Outdated
Comment thread src/modelarrayio/cli/to_modelarray.py Outdated

@tien-tong tien-tong left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation:

  • plot_voxel_workflow.py (line 125) still shows --output-ext, which no longer exists.
  • plot_cifti_workflow.py (line 110) still shows --example-cifti, but the parser expects --example-file.
  • outputs.rst (line 182) says MIF export writes .mif, but the code defaults to .mif.gz.

@tsalo

tsalo commented Apr 24, 2026

Copy link
Copy Markdown
Member Author

@tien-tong I think I've address all of your comments. Would you mind taking another look?

@tien-tong tien-tong self-requested a review April 24, 2026 19:13

@tien-tong tien-tong left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattcieslak mattcieslak merged commit cc9b983 into main Apr 24, 2026
8 checks passed
@mattcieslak mattcieslak deleted the simplify-commands branch April 24, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify commands so image type is automatically detected

4 participants